After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 631510 - Missing math.h include
Missing math.h include
Status: RESOLVED FIXED
Product: gnome-shell
Classification: Core
Component: building
2.91.x
Other Linux
: Normal normal
: ---
Assigned To: gnome-shell-maint
gnome-shell-maint
Depends on:
Blocks:
 
 
Reported: 2010-10-06 10:46 UTC by Guido Günther
Modified: 2010-10-11 18:31 UTC
See Also:
GNOME target: ---
GNOME version: ---


Attachments
Include math.h to fix compilation (568 bytes, patch)
2010-10-06 10:46 UTC, Guido Günther
committed Details | Review

Description Guido Günther 2010-10-06 10:46:04 UTC
Created attachment 171818 [details] [review]
Include math.h to fix compilation

Building current git master fails for me on Debian Sid with:

shell-recorder.c: In function ‘create_recording_icon’:
shell-recorder.c:193: error: ‘M_PI’ undeclared (first use in this function)
shell-recorder.c:193: error: (Each undeclared identifier is reported only once
shell-recorder.c:193: error: for each function it appears in.)
make[3]: *** [libgnome_shell_la-shell-recorder.lo] Error 1

Patch to include math.h attached.
Comment 1 Owen Taylor 2010-10-11 18:31:10 UTC
A little unclear to me why you are hitting this and other people aren't, but that patch looks right to me. Pushed (with a small change to reorder the math.h include to preserve alphabetical ordering of the system includes.) Thanks!