After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 631336 - remove lists of gtk+ signal args in gtkdoc-scanobj and -scangobj
remove lists of gtk+ signal args in gtkdoc-scanobj and -scangobj
Status: RESOLVED FIXED
Product: gtk-doc
Classification: Platform
Component: general
1.16
Other Linux
: Normal blocker
: 1.16
Assigned To: gtk-doc maintainers
gtk-doc maintainers
Depends on:
Blocks: 631241
 
 
Reported: 2010-10-04 18:02 UTC by Stefan Sauer (gstreamer, gtkdoc dev)
Modified: 2010-10-20 08:55 UTC
See Also:
GNOME target: ---
GNOME version: ---


Attachments
remove lookup_signal_arg_names() (23.60 KB, patch)
2010-10-04 18:12 UTC, Stefan Sauer (gstreamer, gtkdoc dev)
committed Details | Review

Description Stefan Sauer (gstreamer, gtkdoc dev) 2010-10-04 18:02:25 UTC
With the recent rewrites in gtk some argument types changed:
http://library.gnome.org/devel/gtk/unstable/GtkWidget.html#GtkWidget-draw
GdkRectangle -> cairo_t

This is because of lookup_signal_arg_names() in the two scanners. I think lookup_signal_arg_names() and get_gdk_event() should just be removed. Instead the signals in gtk+ need a documentation blob like it is needed in all other libraries.
Comment 1 Stefan Sauer (gstreamer, gtkdoc dev) 2010-10-04 18:12:51 UTC
Created attachment 171712 [details] [review]
remove lookup_signal_arg_names()
Comment 2 Stefan Sauer (gstreamer, gtkdoc dev) 2010-10-04 18:13:33 UTC
I can do the same for get_gdk_event() if it sounds like a good idea.
Comment 3 Javier Jardón (IRC: jjardon) 2010-10-04 20:32:12 UTC
This seems related: GtkNotebookPage is still showed in ::switch-page signal:
http://library.gnome.org/devel/gtk/unstable/GtkNotebook.html#GtkNotebook-switch-page
Comment 4 Stefan Sauer (gstreamer, gtkdoc dev) 2010-10-20 08:55:52 UTC
Also pushed the 2nd part.

commit 23e5c3c5c7b80e27321925507e089fa9b3f7a364
Author: Stefan Kost <ensonic@users.sf.net>
Date:   Wed Oct 20 11:51:43 2010 +0300

    scan(g)obj: remove special case handling for GdkEvent
    
    Remove get_gdk_event() as those things should be just properly documented in the
    library. Fixes #631336