After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 631147 - Adapt to GTK API changes
Adapt to GTK API changes
Status: RESOLVED FIXED
Product: mutter
Classification: Core
Component: general
unspecified
Other All
: Normal normal
: ---
Assigned To: mutter-maint
mutter-maint
: 631175 (view as bug list)
Depends on:
Blocks:
 
 
Reported: 2010-10-02 02:27 UTC by Benjamin Otte (Company)
Modified: 2010-10-02 17:22 UTC
See Also:
GNOME target: ---
GNOME version: ---

Attachments
Adapt to GTK API changes (6.43 KB, patch)
2010-10-02 02:27 UTC, Benjamin Otte (Company) 		committed Details | Review

Description Benjamin Otte (Company) 2010-10-02 02:27:05 UTC 
This code adapts mutter to the latest changes to GTK in
http://git.gnome.org/browse/gtk+/commit/?id=872ef111ecabf6cd4453590b1e17afd3c9757f28
that remove the dest argument from gdk_pixbuf_get_from_window() and
gdk_pixbuf_get_from_surface().

It also removes the dest argument from meta_gdk_pixbuf_get_from_pixmap()
to match. The function is internal and the argument wasn't used.
Comment 1 Benjamin Otte (Company) 2010-10-02 02:27:07 UTC 
Created attachment 171548 [details] [review]
Adapt to GTK API changes
Comment 2 Colin Walters 2010-10-02 17:12:20 UTC 
Review of attachment 171548 [details] [review]:

This patch looks basically right to me, I haven't looked at every detail though.

If there's nothing specific that worries you about this patch, let's get it in so the shell can build.
Comment 3 Colin Walters 2010-10-02 17:13:32 UTC 
*** Bug 631175 has been marked as a duplicate of this bug. ***