After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 631119 - introspection: Fix build by telling g-ir-scanner what the prefix is
introspection: Fix build by telling g-ir-scanner what the prefix is
Status: RESOLVED FIXED
Product: epiphany
Classification: Core
Component: General
unspecified
Other All
: Normal normal
: ---
Assigned To: Epiphany Maintainers
Epiphany Maintainers
Depends on:
Blocks:
 
 
Reported: 2010-10-01 16:38 UTC by Vincent Untz
Modified: 2010-10-04 09:39 UTC
See Also:
GNOME target: ---
GNOME version: ---

Attachments
introspection: Fix build by telling g-ir-scanner what the prefix is (788 bytes, patch)
2010-10-01 16:38 UTC, Vincent Untz 		none Details | Review

Description Vincent Untz 2010-10-01 16:38:06 UTC 
It's a really simple patch that applies to gnome-2-30 (and most probably master too). And it's needed if you use a recent g-i (something like 0.9.10).
Comment 1 Vincent Untz 2010-10-01 16:38:08 UTC 
Created attachment 171516 [details] [review]
introspection: Fix build by telling g-ir-scanner what the prefix is
Comment 2 Diego Escalante Urrelo (not reading bugmail) 2010-10-03 20:22:57 UTC 
Is this urgent? Xan is away until next week I think. Looks ok to commit to me anyway, I'd say go ahead if we need this (I guess it's breaking seed support?).
Comment 3 Vincent Untz 2010-10-03 20:26:47 UTC 
It's urgent only if you want to build with a recent g-i. Else, it's not :-) So it's up to you.

I have no idea if this breaks seed support, though... It really depends how the gir file was looking like before, and I don't have such a file anymore.
Comment 4 Xan Lopez 2010-10-04 07:48:18 UTC 
(In reply to comment #1)
> Created an attachment (id=171516) [details] [review]
> introspection: Fix build by telling g-ir-scanner what the prefix is

I think the right thing to do now (~0.9.5) is to use --identifier-prefix and --symbol-prefix? --strip-prefix does not even appear in the manpage. But I could be wrong :)
Comment 5 Vincent Untz 2010-10-04 09:06:33 UTC 
(In reply to comment #4)
> (In reply to comment #1)
> > Created an attachment (id=171516) [details] [review] [details] [review]
> > introspection: Fix build by telling g-ir-scanner what the prefix is
> 
> I think the right thing to do now (~0.9.5) is to use --identifier-prefix and
> --symbol-prefix? --strip-prefix does not even appear in the manpage. But I
> could be wrong :)

--strip-prefix is compatible with 0.9.3, which is used in some distros, though. That's what I chose this one.
Comment 6 Xan Lopez 2010-10-04 09:38:59 UTC 
(In reply to comment #5)
> --strip-prefix is compatible with 0.9.3, which is used in some distros, though.
> That's what I chose this one.

Well, ephy master will be drinking the bleeding edge kool-aid in hardcore mode, so I don't think it's worth it doing this kind of thing. I pushed to master the fix using the 0.9.5 syntax.
Comment 7 Vincent Untz 2010-10-04 09:39:52 UTC 
Right, but what about gnome-2-30?