Created attachment 171483 [details] [review]
Add Clutter dependency on gdk-pixbuf in moduleset

Clutter requires gdk-pixbuf to build, but GTK+3 doesn't ship
with it, so we need to build it separately.

Using the gdk-pixbuf that is shipped from the system won't work
on older distributions, since it's part of GTK+2.

Emmanuele holds that it's OK to use gdk-pixbuf from the system's GTK+2, since it's a separate shared object, but IMHO we often get bitten by this. But I don't know, so if you think it's right, we can add gdk-pixbuf to the list of development packages to install rather.

Review of attachment 171483 [details] [review]:

Patch looks fine, commit message is odd since we are already building gdk-pixbuf in our moduleset as a dependency of gtk3 and to get the .gir files for it.

I'd expect something like:

 Clutter also depends on gdk-pixbuf so build gdk-pixbuf before Clutter.

(In fact for me, my moduleset *does* build gdk-pixbuf before Clutter already, but that's probably just coincidental ordering. Having the dependency is certainly right.)

(In reply to comment #3)
> Review of attachment 171483 [details] [review]:
> 
> Patch looks fine, commit message is odd since we are already building
> gdk-pixbuf in our moduleset as a dependency of gtk3 and to get the .gir files
> for it.
Yeah, I was a little confused by our IRC discussion, but indeed the fix is really simple as gdk-pixbuf is already built.

Pushed with fixed commit message as 25fe730.