After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 631068 - GPointingDeviceSettings build fails with gtk+-2.22
GPointingDeviceSettings build fails with gtk+-2.22
Status: RESOLVED WONTFIX
Product: GPointingDeviceSettings
Classification: Other
Component: Core
git master
Other Linux
: Normal normal
: ---
Assigned To: GPointingDeviceSettings-maint
GPointingDeviceSettings-maint
gnome[unmaintained]
Depends on:
Blocks:
 
 
Reported: 2010-10-01 05:55 UTC by Peter
Modified: 2018-08-17 18:37 UTC
See Also:
GNOME target: ---
GNOME version: ---

Attachments
gpointing-device-settings-1.5.1-gtk22.patch (8.08 KB, patch)
2010-11-10 12:35 UTC, Peter 		none Details | Review

Description Peter 2010-10-01 05:55:52 UTC 
Current gpointingdevicesettings git (and latest release) fails to build with the following error:

  CCLD   gpointing-device-settings
./.libs/libgpds.so: undefined reference to `GDK_DISPLAY'
collect2: ld returned 1 exit status
make[2]: *** [gpointing-device-settings] Error 1
make[2]: Leaving directory `/home/peter/gpointing-device-settings/src'
make[1]: *** [all-recursive] Error 1
make[1]: Leaving directory `/home/peter/gpointing-device-settings'
make: *** [all] Error 2

Originally this bug was reported here: http://bugs.gentoo.org/339198

Thank you in advance for help.
Comment 1 André Klapper 2010-10-17 15:21:26 UTC 
That is because configure.ac states
GPDS_CFLAGS="$GPDS_CFLAGS -DGTK_DISABLE_DEPRECATED"
GPDS_CFLAGS="$GPDS_CFLAGS -DGDK_DISABLE_DEPRECATED"
GPDS_CFLAGS="$GPDS_CFLAGS -DG_DISABLE_DEPRECATED"

Basically
 sed -i -e 's/GDK_DISPLAY()/GDK_DISPLAY_XDISPLAY (gdk_display_get_default ())/'
should fix this.
Comment 2 Peter 2010-11-10 12:35:16 UTC 
Created attachment 174192 [details] [review]
gpointing-device-settings-1.5.1-gtk22.patch

This is a patch to fix this issue. Please, review and apply. Also too many changes done in git so it's worth to release new version I think...
Comment 3 Gianluca Sforna 2010-12-13 11:22:29 UTC 
(In reply to comment #1)
> Basically
>  sed -i -e 's/GDK_DISPLAY()/GDK_DISPLAY_XDISPLAY (gdk_display_get_default ())/'
> should fix this.

I'm applying a patch in the Fedora package for this issue, but replaced the above with the equivalent:

sed -i -e 's/GDK_DISPLAY()/gdk_x11_get_default_xdisplay()/'
Comment 4 Vincent Untz 2011-02-14 11:47:24 UTC 
(In reply to comment #1)
> That is because configure.ac states
> GPDS_CFLAGS="$GPDS_CFLAGS -DGTK_DISABLE_DEPRECATED"
> GPDS_CFLAGS="$GPDS_CFLAGS -DGDK_DISABLE_DEPRECATED"
> GPDS_CFLAGS="$GPDS_CFLAGS -DG_DISABLE_DEPRECATED"

And configure shouldn't do that. Those flags should not be used in tarballs!
Comment 5 André Klapper 2018-08-17 18:37:01 UTC 
GPointingDeviceSettings is not under active development anymore and saw its last non-cosmetic code changes in 2010. Its codebase has been archived:
https://gitlab.gnome.org/Archive/gpointing-device-settings/commits/master

Closing this report as WONTFIX as part of Bugzilla Housekeeping to reflect
reality. Please feel free to reopen this ticket (or rather transfer the project
to GNOME Gitlab, as GNOME Bugzilla is deprecated) if anyone takes the
responsibility for active development again.