Created attachment 171394 [details] [review]
Use new GTK3 drawing APIs

Created attachment 171395 [details] [review]
Add build dependency on gtk3

Created attachment 171396 [details] [review]
Replace GDK_keyname with GDK_KEY_keyname

Created attachment 171397 [details] [review]
Drop GTK_OBJECT usage

Created attachment 171398 [details] [review]
Remove GDK_DISPLAY() usage

Comment on attachment 171397 [details] [review]
Drop GTK_OBJECT usage

svu already beat you to this one in commit
b1079544e9585ee01b31b6e882afceb4aac938da

Review of attachment 171398 [details] [review]:

Trivial, clean straightforward. Committed.

Review of attachment 171396 [details] [review]:

Committed, thanks.

Thanks, I committed a couple of patches. 2 questions:
1. What's about rendering? Is the current code using deprecated API?
2. Why dependency on 2.90 if my current 2.22 have all those APIs already?

(In reply to comment #9)
> Thanks, I committed a couple of patches. 2 questions:
> 1. What's about rendering? Is the current code using deprecated API?
> 2. Why dependency on 2.90 if my current 2.22 have all those APIs already?

Regarding 2) maybe Matthias can instruct us here but I wanted to ensure it was going to link to gtk3 since gtk2 and 3 are parallel installed.

Ghm, what happens if people want gnome2 env and some gtk3 apps? Will they have to install libgnomekbd linked with gtk2?

Was there any discussions to make libs "universal" so that they could use "whatever gtk is around" (if they use interfaces present in both worlds)?

I think the only problem left in here is the use of GdkPixmap here:

struct _GkbdKeyboardDrawing {
        /*< private > */

        GtkDrawingArea parent;

        GdkPixmap *pixmap;

What's the right thing to replace that with?

Oh, I see that's what the first patch is about. Sorry for the noise.

Review of attachment 171394 [details] [review]:

Grand, committed, thanks!

Review of attachment 171395 [details] [review]:

committed

Everything is in git now. Thanks a bunch!