After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 630724 - Update for GTK3 rendering-cleanup
Update for GTK3 rendering-cleanup
Status: RESOLVED FIXED
Product: gnome-desktop
Classification: Core
Component: libgnome-desktop
unspecified
Other All
: Normal normal
: ---
Assigned To: Desktop Maintainers
Desktop Maintainers
Depends on:
Blocks:
 
 
Reported: 2010-09-27 12:23 UTC by Benjamin Otte (Company)
Modified: 2010-09-29 16:08 UTC
See Also:
GNOME target: 3.0
GNOME version: ---

Attachments
gnome-bg: Update for GTK3 changes (24.66 KB, patch)
2010-09-27 12:23 UTC, Benjamin Otte (Company) 		reviewed Details | Review
an additional patch (780 bytes, patch)
2010-09-27 22:07 UTC, Matthias Clasen 		none Details | Review

Description Benjamin Otte (Company) 2010-09-27 12:23:51 UTC 
This patch is the simplest way to update gnome-desktop to the changes that just landed in GTK. Christian Persch has a branch in gnome git, but that branch does some more changes.
Unfortunately I can't really test these changes right now because my GTK3 Nautilus goes all crazy and doesn't seem to work right. There doesn't seem to be any simple application to test gnome-bg with I guess?
Comment 1 Benjamin Otte (Company) 2010-09-27 12:23:53 UTC 
Created attachment 171197 [details] [review]
gnome-bg: Update for GTK3 changes
Comment 2 Matthias Clasen 2010-09-27 22:07:26 UTC 
Created attachment 171238 [details] [review]
an additional patch

Here is an additional patch to avoid warnings from gdk_error_trap_pop()
Comment 3 Matthias Clasen 2010-09-29 12:00:15 UTC 
Review of attachment 171197 [details] [review]:

::: libgnome-desktop/gnome-bg.c
@@ +973,2 @@
  *
  * Since: 2.20

Should probably remove since markers when changing the api.

@@ +1232,2 @@
 /**
+ * gnome_bg_get_surface_from_root:

Here you change the function name in the doc comment, but not in the code.
Comment 4 Benjamin Otte (Company) 2010-09-29 16:08:48 UTC 
Pushed the patch after fixing your comments and renaming all "pixmap" to "surface".