GNOME Bugzilla – Bug 630497
[seek] sprinkle GST_DEBUG_BIN_TO_DOT_FILE_WITH_TS to dump pipeline to dot file
Last modified: 2011-11-07 23:42:29 UTC
Created attachment 171007 [details] [review] adds two new buttons Two useful buttons: - go end button, which shows the very last movie frame - dump .dot button, which saves the current pipeline to the .dot file, provided the respective environment variable is set.
That's not quite right, a seek to the duration of a file should post EOS immediately without decoding any frames.
Yes, you're right. I've added this while was experimenting with my own player, and didn't correct it here. Sorry. Finally, in my own player, I've come to another solution: start the reverse playback and paus the pipeline on GST_STATE_CHANGE.
Created attachment 175224 [details] [review] Adding one button, to dump dot file Seek to end of file needs more work yet.
Review of attachment 175224 [details] [review]: ::: tests/examples/seek/seek.c @@ +39,3 @@ #ifdef G_OS_WIN32 #include <gdk/gdkwin32.h> +#include <direct.h> Why do you add this new header? @@ +1741,3 @@ + if(g_setenv("GST_DEBUG_DUMP_DOT_DIR",(const gchar*)getcwd(cwd,MAXPATHLEN),TRUE)) + GST_DEBUG("GST_DEBUG_DUMP_DOT_DIR=%s",g_getenv("GST_DEBUG_DUMP_DOT_DIR")); + g_free(cwd); You should use g_get_current_dir(), which returns a newly allocated string in the correct encoding
I don't think we need a button to dump the dot file, just add a few GST_DEBUG_BIN_TO_DOT_FILE_WITH_TS() in strategic places (prerolled, error) and let the user set the DOT_DIR to get them dumped.
> Why do you add this new header? Sorry, it's a typo. It should read #include <dirent.h> > You should use g_get_current_dir(), Yes, that's better, agree.
I agree with tim, having UI only makes sense if you e.g. allow to configure the details (flags). Vladimir, are you interested in changing your patch to add the GST_DEBUG_BIN_TO_DOT_FILE_WITH_TS() macros as tim suggested.
It seems to me, this example GUI application allows setting flags, no? It has several checkboxes. Sorry, I don't remember exactly, this was rather long time ago. If I am wrong, then Tim's suggestion is reasonable, and I agree with it.
Vladimir, I am not talking about seek flags, but the flags for the pipeline dumping.
Ah, yes, now I see. Then, I agree with Tim's suggestion, macros would be enough.
Vladimir, do you have any update for the bug ?
No. I don't currently do any work, related to the GStreamer, so don't have any updates. I also thought that this bug was resolved.
commit c6c6c2e75e57e827418e9f7ff2db55c544736884 Author: Tim-Philipp Müller <tim.muller@collabora.co.uk> Date: Mon Nov 7 23:41:33 2011 +0000 examples: sprinkle GST_DEBUG_BIN_TO_DOT_FILE_WITH_TS in seek test utility https://bugzilla.gnome.org/show_bug.cgi?id=630497