GNOME Bugzilla – Bug 630322
make seek example work with windows
Last modified: 2011-06-15 17:42:41 UTC
While trying to use $GST_PLUGINS_BASE/tests/examples/seek/seek.c in windows, its impossible to do this. The attached patches add 1. The ability of the seek sample to work in windows (several #defines). 2. Variable number of gradations on the gtk_adjustment 3. Two useful buttons: - go end button, which shows the very last movie frame - dump .dot button, which saves the current pipeline to the .dot file, provided the respective environment variable is set.
Created attachment 170816 [details] [review] Compile in windows (at least in OSSBuild)
Created attachment 170817 [details] [review] adds #define for number of ticks in gtk_adjustment
Created attachment 170818 [details] [review] Adds two new buttons
(In reply to comment #1) > Created an attachment (id=170816) [details] [review] > Compile in windows (at least in OSSBuild) You should use DEFAULT_AUDIOSINK, DEFAULT_VIDEOSINK, etc instead of hardcoding some values depending on the platform. Also, please file another bug for the two other patches, better don't have patches doing completely unrelated things in the same bug.
(In reply to comment #4) > (In reply to comment #1) > > Created an attachment (id=170816) [details] [review] [details] [review] > > Compile in windows (at least in OSSBuild) > > You should use DEFAULT_AUDIOSINK, DEFAULT_VIDEOSINK, etc instead of hardcoding > some values depending on the platform. They were already. I simply added a couple windows-related. Since these defines are related to the configuration, which developer is free to change according to his needs of testing, I think, these DEFAULTs should be added along with existing ones. > Also, please file another bug for the two other patches, better don't have > patches doing completely unrelated things in the same bug.
Created attachment 171001 [details] [review] Edition of seek_compile_win.patch, added DEFAULT_AUDIOSINK and DEFAULT_VIDEOSINK Just edited the existing file. Hope this will work.
Comment on attachment 171001 [details] [review] Edition of seek_compile_win.patch, added DEFAULT_AUDIOSINK and DEFAULT_VIDEOSINK patch: **** malformed patch at line 50: #define FILL_INTERVAL 100 Could you get a new patch? :) Also please use git format-patch to generate patches, this way you also put the commit message, your name, etc into the patch.
Created attachment 171184 [details] [review] One more attempt. Several defines to make seek sample work in win32 Have pulled fresh master revision and made diffs agains it.
Created attachment 171185 [details] [review] Using configured sinks in playbin and playbin2, trying to embed video in the gtk widget
Thanks, I've committed this now (changed your patches a little bit): commit 02773936ea9c9edc962827ba689b016e864bca39 Author: Vladimir Eremeev <eremeev@atlantis.ru> Date: Mon Sep 27 13:32:31 2010 +0400 seek: set selected/default audio/video sinks on playbin and playbin https://bugzilla.gnome.org/show_bug.cgi?id=630322 commit cf90887aea39d65b759c34f685dedc6a375c90d8 Author: Tim-Philipp Müller <tim.muller@collabora.co.uk> Date: Wed May 25 19:03:44 2011 +0100 seek: add --audiosink and --videosink command line options commit 790dc35363fc420ca124479878782dce4ceb0929 Author: Tim-Philipp Müller <tim.muller@collabora.co.uk> Date: Wed May 25 18:50:34 2011 +0100 seek: use the right GDK defines to differentiate between the backends commit 48f5e301c880bdf5e81b71c4023381f0a96b2d1a Author: Tim-Philipp Müller <tim.muller@collabora.co.uk> Date: Wed May 25 18:45:33 2011 +0100 seek: use gst_filename_to_uri() to convert a filename to a uri commit bce2650c9958ab85668ab6e930624728579d1db0 Author: Vladimir Eremeev <eremeev@atlantis.ru> Date: Mon Sep 27 12:46:54 2010 +0400 seek: make seek example work in win32 https://bugzilla.gnome.org/show_bug.cgi?id=630322