After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 629903 - Support Call API
Support Call API
Status: RESOLVED FIXED
Product: empathy
Classification: Core
Component: VoIP
2.29.x
Other Linux
: Normal enhancement
: ---
Assigned To: empathy-maint
Depends on:
Blocks: 582597
 
 
Reported: 2010-09-17 08:42 UTC by Guillaume Desmottes
Modified: 2011-08-29 10:12 UTC
See Also:
GNOME target: ---
GNOME version: ---


Attachments
don't link all the binaries against farsight (104.53 KB, application/octet-stream)
2011-02-09 17:19 UTC, Emilio Pozuelo Monfort
Details

Description Guillaume Desmottes 2010-09-17 08:42:43 UTC
In order to implement the new Muji-compatible call UI (bug #629902) Empathy will have to gain support of the new Call API:
http://telepathy.freedesktop.org/spec/Channel_Type_Call.html

Ideally, we should have a TpCall high level object inheriting from TpChannel. While the API is not stable, we could start implementing this object in Empathy and move it later to tp-glib.

Note that currently EmpathyTpCall is using the old API so we may have to rename it first.

This is blocked by having channel factory support in tp-glib: https://bugs.freedesktop.org/show_bug.cgi?id=29973
Comment 1 Guillaume Desmottes 2010-09-17 09:39:45 UTC
We'll need Call support in tp-fs as well : https://bugs.freedesktop.org/show_bug.cgi?id=29590
Comment 2 Emilio Pozuelo Monfort 2010-11-18 11:24:04 UTC
FTR so I don't forget :)

<cassidy> pochu, ok, so I'd say start implementing TpCallChannel in tp-yell for now. See TpStreamTubeChannel for an example of TpChannel subclass in tp-glib
<cassidy> I suspect you'll be shortly blocked on https://bugs.freedesktop.org/show_bug.cgi?id=31583  which should give smcv one more reason to fix it :)
Comment 3 Emilio Pozuelo Monfort 2010-12-24 11:44:45 UTC
Please review. More branches will follow soon.

http://git.collabora.co.uk/?p=user/pochu/telepathy-logger.git;a=shortlog;h=refs/heads/abstract-log-entries
Comment 4 Emilio Pozuelo Monfort 2010-12-24 11:45:24 UTC
EBUG, ignore the previous comment...
Comment 5 Emilio Pozuelo Monfort 2011-02-03 14:26:57 UTC
http://git.collabora.co.uk/?p=user/pochu/empathy.git;a=shortlog;h=refs/heads/streamed-media

Various Call -> StreamedMedia renames in Empathy, since we'll add Call classes for Call channels, and these are handling StreamedMedia channels, not Call ones.
Comment 6 Guillaume Desmottes 2011-02-03 14:45:18 UTC
If "make check" pass and you can still make calls, that's fine with me :)
Comment 7 Emilio Pozuelo Monfort 2011-02-03 15:02:58 UTC
Forgot to update po/POTFILES.in. Updated and merged.
Comment 8 Emilio Pozuelo Monfort 2011-02-09 17:17:05 UTC
emilio@marte:~/src/empathy$ ldd /opt/empathy/bin/empathy | grep far
emilio@marte:~/src/empathy$ 

Top 5 commits of http://git.collabora.co.uk/?p=user/pochu/empathy.git;a=shortlog;h=refs/heads/trivia

That's needed since we need to link against tp-farstream for Call, but we can't mix tp-farstream and tp-farsight, so we'll have empathy-av link against tp-farsight and manage StreamedMedia, and a new empathy-call binary linking against tp-farstream and managing Call.
Comment 9 Emilio Pozuelo Monfort 2011-02-09 17:19:21 UTC
Created attachment 180490 [details]
don't link all the binaries against farsight

Squashed diff for the above branch
Comment 10 Guillaume Desmottes 2011-02-10 08:44:32 UTC
++ (master and 2.34 please).
Comment 11 Emilio Pozuelo Monfort 2011-02-10 10:30:45 UTC
Thanks, pushed to both master and gnome-2-34.
Comment 12 Guillaume Desmottes 2011-03-03 13:38:39 UTC
The 2.34 branch already supports Call. We'll backport it to master later as it involves some UI and string changes so that will be for 3.2