Created attachment 170377 [details] [review]
Fix for FormClient.cs

I had a problem with Gallery Export when I included characters like "á" or "č" in photo descriptions. The export was unsuccessful, with an error message saying that the number of bytes sent was not identical to ContentLength (I'm sorry, I didn't record the full error message).

F-spot also regularly crashed (no error message, window simply disappeared) when I tried creating a Gallery2 album through its interface with those same characters in the album's description.

These problems occur in versions 6.1.5 and 7.3 and are always reproducible.

I believe I also found the source of these problems, which is in the FormClient class. As I understand it, this class takes care of submitting the HTTP form to the Gallery server. It seems that when Unicode characters are included in the strings that it sends (such as a photo description), it fails to compute the correct ContentLength. In case of albums, there is also no exception catching involved, so f-spot simply crashes. In case of photo imports, the problem exception is caught and so I get an error message.

Here's what fixed it for me (version 0.7.3):

==============================================================================
$ diff FormClient.cs_orig FormClient.cs
118c118
< 			length += value.Length + 2;
---
> 			length += Encoding.Default.GetBytes(value).Length + 2;
==============================================================================

I'm not sure whether "Encoding.Default" is the right way to get the right encoding, but apart from that I believe this fix should be suitable.

I'm sorry if this bug report is not as it should be, it is one of my first ones. If you need any more information, just tell me and I'll post it.