After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 629775 - Use only one Makefile for all JS modules
Use only one Makefile for all JS modules
Status: RESOLVED FIXED
Product: gnome-shell
Classification: Core
Component: building
unspecified
Other Linux
: Normal normal
: ---
Assigned To: gnome-shell-maint
gnome-shell-maint
Depends on:
Blocks:
 
 
Reported: 2010-09-15 16:11 UTC by Giovanni Campagna
Modified: 2010-09-15 16:40 UTC
See Also:
GNOME target: ---
GNOME version: ---

Attachments
Use non recursive automake for JS (4.00 KB, patch)
2010-09-15 16:11 UTC, Giovanni Campagna 		committed Details | Review

Description Giovanni Campagna 2010-09-15 16:11:12 UTC 
Currently, JS modules have various submodules, and each one requires its own Makefile, that is configured and made separately.
Automake has a feature that allows for mirroring the source tree in the installation tree, which means that separate installation dirs don't need to be declared (and an extra basename step is avoided).
Comment 1 Giovanni Campagna 2010-09-15 16:11:41 UTC 
Created attachment 170351 [details] [review]
Use non recursive automake for JS

Use only one Makefile for all JS module, to make faster builds and
to increase maintenability.
Comment 2 Colin Walters 2010-09-15 16:23:23 UTC 
Review of attachment 170351 [details] [review]:

It looks like the attached js/Makefile.am is empty?
Comment 3 Colin Walters 2010-09-15 16:24:21 UTC 
Review of attachment 170351 [details] [review]:

Nevermind; splinter bug apparently.

Looks good to me; I'm a huge fan of non-recursive automake.
Comment 4 Florian Müllner 2010-09-15 16:40:10 UTC 
I don't think Giovanni has push access ...

Attachment 170351 [details] pushed as 2adfca0 - Use non recursive automake for JS