GNOME Bugzilla – Bug 629716
Migrate Folks to GDBus
Last modified: 2011-06-23 16:37:15 UTC
We've got a compile-time warning for using D-Bus bindings in Folks. We should switch to GDBus when feasible (which may be now).
Blocked by https://bugs.freedesktop.org/show_bug.cgi?id=28782
(setting Future, since tp-glib won't be migrating in the short-term)
Created attachment 189564 [details] [review] Port Folks (the Telepathy backend) to GDBus This should port us over to GDBus completely. It turns out we weren't directly dependent upon dbus-glib after all. I've tested this with both Vala 0.12.1 and git master (ie, 0.14.x; this included re-building vala, telepathy-glib, eds, folks, empathy with this version). It seems to work fine in both cases. I hit some massive trouble in testing, but it turns out to be an issue with session handling changing under my feet (every build combination was broken with my usual 'ssh -X otheruser@localhost; create special dbus session). However, doing things the slow way (using fast user switching and logging in as the other user through GDM) makes things work for both Vala 0.12.1 and 0.14.x. Patches from branch: http://cgit.collabora.com/git/user/treitter/folks.git/log/?h=bgo629716-port-to-gdbus
Comment on attachment 189564 [details] [review] Port Folks (the Telepathy backend) to GDBus Looks good. Are you planning on following up with patches for libsocialweb and the test cases? A quick git grep dbus shows that dbus-glib is used for lsw and telepathy's test cases. The tracker backend is already using gdbus so all good there.
Created attachment 190479 [details] [review] Port all but the Tp test library to GDBus Patches for branch: http://cgit.collabora.com/git/user/treitter/folks.git/log/?h=bgo629716-port-to-gdbus-7 We can't completely ditch our dependency upon dbus-glib due to fdo#28782 - so I've split the remaining work out into bug #653198. This way, we can merge most of the work (which also happens to un-break the test suite when building with Vala 0.14).
Review of attachment 190479 [details] [review]: Looks OK to me. How does it interact with my patch from bug #652472?
(In reply to comment #6) > Review of attachment 190479 [details] [review]: > > Looks OK to me. How does it interact with my patch from bug #652472? I rebased my branch upon that and it works fine.
Merged: commit daf213dc62ee123ab7010edcb18c368d3969a513 Author: Travis Reitter <travis.reitter@collabora.co.uk> Date: Wed Jun 22 16:05:58 2011 -0700 Don't make the folks-telepathy docs depend directly upon dbus-glib. Closes: bgo#629716 - Migrate Folks to GDBus NEWS | 1 + docs/Makefile.am | 1 - 2 files changed, 1 insertions(+), 1 deletions(-) commit e2b872732403113024f1560e7a9f05de0444951e Author: Travis Reitter <travis.reitter@collabora.co.uk> Date: Wed Jun 22 15:46:28 2011 -0700 Don't make the Libsocialweb backend depend directly upon dbus-glib. Helps: bgo#629716 - Migrate Folks to GDBus backends/libsocialweb/lib/Makefile.am | 1 - 1 files changed, 0 insertions(+), 1 deletions(-) commit 5e2c7adeff14517e36cd9d55335791833da64b5b Author: Travis Reitter <travis.reitter@collabora.co.uk> Date: Wed Jun 22 15:38:16 2011 -0700 Don't make the Telepathy tests depend directly upon dbus-glib. Helps: bgo#629716 - Migrate Folks to GDBus tests/telepathy/Makefile.am | 1 - 1 files changed, 0 insertions(+), 1 deletions(-) commit 67b5617bcbb2109dd43d9f25feae52c7efaeaa1f Author: Travis Reitter <travis.reitter@collabora.co.uk> Date: Wed Jun 22 13:41:15 2011 -0700 Handle both the dbus-glib and GDBus missing logger errors. Helps: bgo#629716 - Migrate Folks to GDBus tests/lib/telepathy/contactlist/backend.c | 13 +++++++++++-- 1 files changed, 11 insertions(+), 2 deletions(-) commit be621be89c3e25c5875e245560328b3b556675ad Author: Travis Reitter <travis.reitter@collabora.co.uk> Date: Wed Jun 22 13:35:44 2011 -0700 Update Tp test backend suppression to match GDBus behavior. Helps: bgo#629716 - Migrate Folks to GDBus tests/lib/telepathy/contactlist/backend.c | 3 +-- 1 files changed, 1 insertions(+), 2 deletions(-) commit a32e8adc4dcc15d6ac207d9c9dd6c9d7d44cd174 Author: Travis Reitter <travis.reitter@collabora.co.uk> Date: Tue Jun 21 16:31:18 2011 -0700 Cut unnecessary log message suppressions in the Aggregation test. Helps: bgo#629716 - Migrate Folks to GDBus tests/folks/aggregation.vala | 35 ----------------------------------- 1 files changed, 0 insertions(+), 35 deletions(-) commit 09bf32c22843eaa9cf34bd091d864dfa85bf4d63 Author: Travis Reitter <travis.reitter@collabora.co.uk> Date: Tue Jun 21 16:14:04 2011 -0700 Properly disconnect the logger::invalidated handler. Helps: bgo#629716 - Migrate Folks to GDBus backends/telepathy/lib/tpf-persona-store.vala | 18 ++++++++++++------ 1 files changed, 12 insertions(+), 6 deletions(-) commit 8b2449f753ee91cabb47895e26293737da640e69 Author: Travis Reitter <travis.reitter@collabora.co.uk> Date: Tue Jun 7 16:16:47 2011 -0700 Port Tpf.Logger to GDBus. Helps: bgo#629716 - Migrate Folks to GDBus backends/telepathy/lib/tpf-logger.vala | 58 +++++++++++++++++-------------- 1 files changed, 32 insertions(+), 26 deletions(-) commit 17814e50568b923df74d41d354b8108fdfd0ee22 Author: Travis Reitter <travis.reitter@collabora.co.uk> Date: Tue Jun 7 16:15:31 2011 -0700 Factor out Tpf.Logger.prepare() from its constructor. Helps: bgo#629716 - Migrate Folks to GDBus backends/telepathy/lib/tpf-logger.vala | 14 ++++++++++++-- backends/telepathy/lib/tpf-persona-store.vala | 1 + 2 files changed, 13 insertions(+), 2 deletions(-) commit fa396c2ca0c6116959d4397438154de15393422c Author: Travis Reitter <travis.reitter@collabora.co.uk> Date: Wed Jun 8 08:39:28 2011 -0700 Use the GLib definition of Error instead of DBus.Error. Helps: bgo#629716 - Migrate Folks to GDBus backends/telepathy/lib/tpf-logger.vala | 14 +++++++------- backends/telepathy/lib/tpf-persona-store.vala | 6 +++--- 2 files changed, 10 insertions(+), 10 deletions(-) commit 0f45b1150d8380d170d3cdaebdfc576f9060e52c Author: Travis Reitter <travis.reitter@collabora.co.uk> Date: Tue Jun 7 11:23:43 2011 -0700 Use the GLib definition for Object. Helps: bgo#629716 - Migrate Folks to GDBus backends/telepathy/lib/tpf-logger.vala | 2 +- 1 files changed, 1 insertions(+), 1 deletions(-) commit ba83c9014931c9bbf897de14d7dbaa2876ccea32 Author: Travis Reitter <travis.reitter@collabora.co.uk> Date: Tue Jun 7 11:21:53 2011 -0700 Use the GLib definition for ObjectPath. Helps: bgo#629716 - Migrate Folks to GDBus backends/telepathy/lib/tpf-logger.vala | 12 ++++++------ 1 files changed, 6 insertions(+), 6 deletions(-) commit 627643e93b4b38a1904684f9361b498d0fe7ec3a Author: Travis Reitter <travis.reitter@collabora.co.uk> Date: Tue Jun 7 11:16:21 2011 -0700 Don't build dbus-glib into Telepathy backend. Helps: bgo#629716 - Migrate Folks to GDBus backends/telepathy/lib/Makefile.am | 3 --- configure.ac | 3 --- 2 files changed, 0 insertions(+), 6 deletions(-)