After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 629676 - Adjust for TelepathyGLib-0.12.gir symbol breaks
Adjust for TelepathyGLib-0.12.gir symbol breaks
Status: RESOLVED FIXED
Product: folks
Classification: Platform
Component: Telepathy backend
git master
Other Linux
: Normal normal
: gnome-2.32
Assigned To: folks-maint
folks-maint
Depends on: 629691
Blocks:
 
 
Reported: 2010-09-14 15:44 UTC by Travis Reitter
Modified: 2010-09-14 19:54 UTC
See Also:
GNOME target: ---
GNOME version: ---


Attachments
Adjust for the rename of IntSet → Intset (2.35 KB, patch)
2010-09-14 15:45 UTC, Travis Reitter
none Details | Review
Adjust for the rename of IntSet → Intset (try 2) (3.16 KB, patch)
2010-09-14 16:00 UTC, Travis Reitter
accepted-commit_now Details | Review

Description Travis Reitter 2010-09-14 15:44:07 UTC
The telepathy-glib bug https://bugs.freedesktop.org/show_bug.cgi?id=30134 will end up with changes to its GIR that require some changes in Folks (renaming IntSet to Intset).
Comment 1 Travis Reitter 2010-09-14 15:45:47 UTC
Created attachment 170255 [details] [review]
Adjust for the rename of IntSet → Intset

Squashed diff of branch:

http://git.collabora.co.uk/?p=user/treitter/folks.git;a=shortlog;h=refs/heads/fdo30134-intset-renames
Comment 2 Travis Reitter 2010-09-14 16:00:39 UTC
Created attachment 170256 [details] [review]
Adjust for the rename of IntSet → Intset (try 2)

Squashed diff of branch:

http://git.collabora.co.uk/?p=user/treitter/folks.git;a=shortlog;h=refs/heads/fdo30134-intset-renames2

===

As Philip pointed out, this patch should be more aggressive in cutting obsolete symbols.
Comment 3 Philip Withnall 2010-09-14 16:02:33 UTC
Review of attachment 170256 [details] [review]:

Looks good as soon as the tp-glib changes have been pushed.
Comment 4 Philip Withnall 2010-09-14 17:41:57 UTC
When building with this branch, I came across some Vala bugs. Filed as bug #629691.
Comment 5 Travis Reitter 2010-09-14 19:54:00 UTC
Merged to master:

commit f69f90d83b92371ea10bd536793da80a4655b662
Author: Travis Reitter <travis.reitter@collabora.co.uk>
Date:   Tue Sep 14 08:33:36 2010 -0700

    Cut out unnecessary tp-glib version checking.

 configure.ac          |   13 -------------
 tests/Makefile.am     |    5 +----
 tests/lib/Makefile.am |    8 +++-----
 3 files changed, 4 insertions(+), 22 deletions(-)

commit af444ebede64877359a28e91ad1991ac77856a28
Author: Travis Reitter <travis.reitter@collabora.co.uk>
Date:   Tue Sep 14 08:34:52 2010 -0700

    Update the name for TelepathyGLib.Intset

 backends/telepathy/lib/tpf-persona-store.vala |    6 +++---
 configure.ac                                  |    2 +-
 2 files changed, 4 insertions(+), 4 deletions(-)