After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 629598 - Do not use deprecated gtk_widget_size_request()
Do not use deprecated gtk_widget_size_request()
Status: RESOLVED FIXED
Product: gtk+
Classification: Platform
Component: .General
2.90.x
Other All
: Normal normal
: ---
Assigned To: gtk-bugs
gtk-bugs
Depends on:
Blocks:
 
 
Reported: 2010-09-14 01:25 UTC by Javier Jardón (IRC: jjardon)
Modified: 2010-09-15 01:05 UTC
See Also:
GNOME target: ---
GNOME version: ---

Attachments
Do not use deprecated gtk_widget_size_request() (60.53 KB, patch)
2010-09-14 01:34 UTC, Javier Jardón (IRC: jjardon) 		committed Details | Review

Description Javier Jardón (IRC: jjardon) 2010-09-14 01:25:39 UTC 
Use gtk_size_request_get_size() instead
Comment 1 Javier Jardón (IRC: jjardon) 2010-09-14 01:34:18 UTC 
Created attachment 170208 [details] [review]
Do not use deprecated gtk_widget_size_request()
Comment 2 Tristan Van Berkom 2010-09-14 19:27:29 UTC 
Review of attachment 170208 [details] [review]:

I took the time again to go over this huge patch line by line.

All the code looks fine and in place, I wonder if in gtkwidget.c 
where gtk_widget_get_size_request() is documented; if it should
read "To get the size a widget will actually request" instead of
saying "To get the size a widget will actually use".

However, this documentation was already a bit ambiguous about 
that detail before your patch.
Comment 3 Javier Jardón (IRC: jjardon) 2010-09-15 01:05:06 UTC 
Comment on attachment 170208 [details] [review]
Do not use deprecated gtk_widget_size_request()

committed with your documentation fix, thanks for the review!

commit b140884fec56d0ac5f15fe3937879a7a1dd6f0c1