GNOME Bugzilla – Bug 629503
Add async versions of g_unix_connection_{receive,send}_credentials
Last modified: 2012-01-18 14:22:54 UTC
As said in a comment in gunixconnection.c, I'd need an async version of g_unix_connection_send_credentials() and g_unix_connection_receive_credentials(). Depending of the way we'll solve bug #629267 this API should maybe include the byte sent/received.
Created attachment 205361 [details] [review] GUnixConnection: add async variant for send/receive_credentials()
git branch: http://cgit.collabora.com/git/user/xclaesse/glib.git/log/?h=async-creds
Comment on attachment 205361 [details] [review] GUnixConnection: add async variant for send/receive_credentials() You need to update gio/gio.symbols. The indentation should match the existing indentation style. Eg: >+ if (!g_unix_connection_send_credentials ((GUnixConnection *) object, >+ cancellable, &error)) the args on the second line should line up with the args on the first line. Also, use G_UNIX_CONNECTION(), not a plain C cast. >+ * Returns: %TRUE if the operation was successfull, otherwise %FALSE. one "l" in "successful" >+ if (g_simple_async_result_propagate_error (G_SIMPLE_ASYNC_RESULT (result), >+ error)) >+ return FALSE; >+ >+ g_return_val_if_fail (g_simple_async_result_is_valid (result, >+ G_OBJECT (connection), g_unix_connection_send_credentials_async), FALSE); the g_return_val_if_fail() should come first. (in both _finish funcs)
Created attachment 205423 [details] [review] GUnixConnection: add async variant for send/receive_credentials()
Comment on attachment 205423 [details] [review] GUnixConnection: add async variant for send/receive_credentials() you need to update gio/gio.symbols as well. OK to commit after fixing that.
Done. Merged. Thanks.