After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 629418 - progressreport: add support for determining stream position from buffer timestamps instead of using queries
progressreport: add support for determining stream position from buffer times...
Status: RESOLVED FIXED
Product: GStreamer
Classification: Platform
Component: gst-plugins-good
git master
Other All
: Normal enhancement
: 0.10.27
Assigned To: GStreamer Maintainers
GStreamer Maintainers
Depends on:
Blocks:
 
 
Reported: 2010-09-12 11:58 UTC by Leo Singer
Modified: 2010-12-06 14:18 UTC
See Also:
GNOME target: ---
GNOME version: ---

Attachments
Proposed patch (4.41 KB, patch)
2010-09-12 11:58 UTC, Leo Singer 		none Details | Review

Description Leo Singer 2010-09-12 11:58:48 UTC 
Created attachment 170076 [details] [review]
Proposed patch

In streams with elements that have broken or dishonest position queries, the progressreport element can produce confusing output.

The attached patch adds a mode in which the position is determined by looking at the buffer metadata, without doing any queries.  Of course, this only works for FORMAT_TIME.  In a slightly fancier version of this patch, duration could be taken from the configured segment.
Comment 1 Mark Nauwelaerts 2010-12-06 11:28:09 UTC 
Modified patch a bit structurally, and also used the buffer stream time (i.e. gst_segment_to_stream_time) and segment duration.


commit 1d4496254dac71bc2494e3f7b296d29534086f97
Author: Mark Nauwelaerts <mark.nauwelaerts@collabora.co.uk>
Date:   Mon Dec 6 12:17:21 2010 +0100

    progressreport: optionally determine progress using buffer metadata
    
    Based on patch by Leo Singer <lsinger at caltech.edu>
    
    Fixes #629418.