After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 628967 - [scanner] Bring back g_file_new_*
[scanner] Bring back g_file_new_*
Status: RESOLVED FIXED
Product: gobject-introspection
Classification: Platform
Component: general
unspecified
Other Linux
: Normal normal
: ---
Assigned To: gobject-introspection Maintainer(s)
gobject-introspection Maintainer(s)
Depends on:
Blocks:
 
 
Reported: 2010-09-07 15:16 UTC by Johan (not receiving bugmail) Dahlin
Modified: 2015-02-07 16:54 UTC
See Also:
GNOME target: ---
GNOME version: ---

Attachments
Go back to previously handling of "static interface methods" (1.52 KB, patch)
2010-09-07 16:47 UTC, Owen Taylor 		none Details | Review
Go back to previously handling of static methods on non-GObjects (2.31 KB, patch)
2010-09-07 17:11 UTC, Owen Taylor 		committed Details | Review

Description Johan (not receiving bugmail) Dahlin 2010-09-07 15:16:48 UTC 
g_file_new_* constructors for GFile (which is an interface) have regressed since Colin landed his scanner rewrite.

It is related to the way static methods are paired, see revision 144cb10 of g-i.
Comment 1 Owen Taylor 2010-09-07 16:47:09 UTC 
Created attachment 169687 [details] [review]
Go back to previously handling of "static interface methods"

We were parsing "static methods" for interfaces, but not actually
writing them to the GIR file. Previous to the scanner rewrite we
just handled them as:

 g_file_new_for_path => Gio.file_new_for_path

So go back to doing that. See bug 572408 for putting them on the
interface instead.
Comment 2 Owen Taylor 2010-09-07 17:11:59 UTC 
Created attachment 169690 [details] [review]
Go back to previously handling of static methods on non-GObjects

Turns out that the last patch didn't restore 100% compatibility with
the pre-rewrite API - we were now generating static methods for
records/boxed objects. Here's a new patch that (as far as I know)
should give us the exact API as previous.

This has a big advantage in not breaking language bindings right
now, though we really should make the change sooner rather than
later.
Comment 3 Johan (not receiving bugmail) Dahlin 2010-09-07 17:14:22 UTC 
Review of attachment 169690 [details] [review]:

Looks good to me, this is the right thing until 572408 is fixed.
Comment 4 Owen Taylor 2010-09-07 17:54:32 UTC 
Attachment 169690 [details] pushed as d80c8a8 - Go back to previously handling of static methods on non-GObjects
Comment 5 André Klapper 2015-02-07 16:54:04 UTC 
[Mass-moving gobject-introspection tickets to its own Bugzilla product - see bug 708029. Mass-filter your bugmail for this message: introspection20150207 ]