After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 628656 - _gdk_windowing_get_startup_notify_id memory leak
_gdk_windowing_get_startup_notify_id memory leak
Status: RESOLVED FIXED
Product: gtk+
Classification: Platform
Component: Backend: X11
2.21.x
Other Linux
: Normal normal
: ---
Assigned To: gtk-bugs
gtk-bugs
Depends on:
Blocks: 627707
 
 
Reported: 2010-09-03 00:42 UTC by David Woodhouse
Modified: 2010-09-03 16:52 UTC
See Also:
GNOME target: ---
GNOME version: ---


Attachments
Proposed patch (1.30 KB, patch)
2010-09-03 11:56 UTC, Matthew Barnes
none Details | Review

Description David Woodhouse 2010-09-03 00:42:23 UTC
==21464== 27 bytes in 1 blocks are definitely lost in loss record 10,810 of 33,527
==21464==    at 0x4A0615D: malloc (vg_replace_malloc.c:195)
==21464==    by 0x3D3D645C80: g_malloc (gmem.c:134)
==21464==    by 0x3D3D65E31D: g_strdup (gstrfuncs.c:101)
==21464==    by 0x3D3FE4AC89: _gdk_windowing_get_startup_notify_id (gdkapplaunchcontext-x11.c:54)
==21464==    by 0x3D3E67898F: g_desktop_app_info_launch_uris (gdesktopappinfo.c:961)
==21464==    by 0x3D3E678BCA: g_desktop_app_info_launch (gdesktopappinfo.c:1042)
==21464==    by 0x5BA0913: attachment_open_file (e-attachment.c:2025)
==21464==    by 0x5BA0C66: attachment_open_save_finished_cb (e-attachment.c:2083)
==21464==    by 0x5BA0669: attachment_save_read_cb (e-attachment.c:2433)
==21464==    by 0x3D3E654ED4: async_ready_callback_wrapper (ginputstream.c:470)
==21464==    by 0x3D3E663E2B: complete_in_idle_cb (gsimpleasyncresult.c:702)
==21464==    by 0x3D3D63EF22: g_main_context_dispatch (gmain.c:2119)
Comment 1 Matthew Barnes 2010-09-03 11:52:34 UTC
The leak is in gdkapplaunchcontext-x11.c.

get_display_name() returns a newly allocated string, which is fed directly into a g_strdup_printf() call.
Comment 2 Matthew Barnes 2010-09-03 11:56:23 UTC
Created attachment 169422 [details] [review]
Proposed patch
Comment 3 Matthias Clasen 2010-09-03 16:52:36 UTC

-- 
Fedora Bugzappers volunteer triage team
https://fedoraproject.org/wiki/BugZappers