After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 628488 - [theoradec] add properties to enable telemetry overlay
[theoradec] add properties to enable telemetry overlay
Status: RESOLVED FIXED
Product: GStreamer
Classification: Platform
Component: gst-plugins-base
0.10.x
Other Linux
: Normal enhancement
: 0.10.31
Assigned To: Tim-Philipp Müller
GStreamer Maintainers
Depends on:
Blocks: 564957
 
 
Reported: 2010-09-01 10:18 UTC by Oleksij Rempel
Modified: 2010-10-10 18:04 UTC
See Also:
GNOME target: ---
GNOME version: ---


Attachments
add telemetry visualisation v1 (5.93 KB, patch)
2010-09-02 20:18 UTC, Oleksij Rempel
none Details | Review
git ready patch (6.82 KB, patch)
2010-09-04 12:34 UTC, Oleksij Rempel
none Details | Review
patch v2 (5.59 KB, patch)
2010-10-08 17:19 UTC, Oleksij Rempel
committed Details | Review

Description Oleksij Rempel 2010-09-01 10:18:52 UTC
Hallo all,
for some time libtheora can show decoding thelemetry. I think it could be great to have it in gstreamer by default and not repatch it all the time.
libtheora should be compieled with "--enable-telemetry"

Here is some more info about it:
http://people.xiph.org/~xiphmont/demo/theora/demo2.html

and here is old patch for gstreamer:
http://people.xiph.org/~msmith/thusnelda-visualisation.patch
Comment 1 Oleksij Rempel 2010-09-02 07:58:49 UTC
If no one working on this now, i will try to update patch.
Comment 2 Sebastian Dröge (slomo) 2010-09-02 08:22:54 UTC
That'd be great, I think nobody is working on it now. Otherwise the bug would be marked as assigned to somebody
Comment 3 Oleksij Rempel 2010-09-02 20:18:45 UTC
Created attachment 169389 [details] [review]
add telemetry visualisation v1

Here is updated patch against current git, it use new API, and more telemetry options. 
to use it you need libtheora compiled with "--enable-telemetry"
use example:

.... ! theoradec vis-mv=0xff vis-mbmode=0xff vis-qi=0xff vis-bits=0xff ! ...

it is better to use one of options at time.
Comment 4 Oleksij Rempel 2010-09-03 13:35:33 UTC
While this patch helped to find one more performance regression for cheese (actually for empahty too), i mark it as blocker for your perf bug 564957

for more info take a look here:
https://docs.google.com/document/pub?id=14GlfUdWGGiC-4ZIpZnvjRGAiMOAsyxIHeWYsp3mzEtE#h.23x3wc-196gn1
Comment 5 Oleksij Rempel 2010-09-04 12:34:25 UTC
Created attachment 169482 [details] [review]
git ready patch

here is updated patch with some style fixes. I'll be happy for any feet back :D
Comment 6 Oleksij Rempel 2010-10-08 17:19:49 UTC
Created attachment 171961 [details] [review]
patch v2
Comment 7 Tim-Philipp Müller 2010-10-10 18:03:24 UTC
Couldn't really make up my mind whether to always expose these properties or not, so just hid them for now if theora wasn't compiled with --enable-telemetry:


commit a044b62cf5763240d5243b9326d886ed34379dab
Author: Tim-Philipp Müller <tim.muller@collabora.co.uk>
Date:   Sun Oct 10 00:52:13 2010 +0100

    theoradec: expose telemetry properties only if libtheora was compiled with --enable-telemetry
    
    Since this is just a debugging feature and libtheora will usually not be
    compiled with that option enabled, we should maybe just hide these properties,
    since they won't work anyway, and avoid confusing warnings.
    
    Also rename properties to make them less cryptic.
    
    https://bugzilla.gnome.org/show_bug.cgi?id=628488

commit ab52e15e3d9ebc2c5a784aa8cc8a4bc15a40edca
Author: Alexey Fisher <bug-track@fisher-privat.net>
Date:   Sat Oct 9 23:49:35 2010 +0100

    theoradec: add properties to enable debugging telemetry overlay
    
    The theora decoder can overlay debugging information on the output
    video. This functionality is only available if libtheora has been
    compiled with --enable-telemetry. For more details see:
    
    http://people.xiph.org/~xiphmont/demo/theora/demo2.html
    
    Based on original patch by Michael Smith <msmith at xiph org>
    
    https://bugzilla.gnome.org/show_bug.cgi?id=628488