After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 628416 - [flvmux] Bad FLV header
[flvmux] Bad FLV header
Status: RESOLVED NOTABUG
Product: GStreamer
Classification: Platform
Component: gst-plugins-good
git master
Other Linux
: Normal normal
: git master
Assigned To: GStreamer Maintainers
GStreamer Maintainers
Depends on:
Blocks:
 
 
Reported: 2010-08-31 13:03 UTC by Dejan Sakelšak
Modified: 2010-08-31 15:42 UTC
See Also:
GNOME target: ---
GNOME version: ---

Attachments
This patch fixes the header bug (2.81 KB, patch)
2010-08-31 13:03 UTC, Dejan Sakelšak 		rejected Details | Review
Fixes a bug of the previous patch (2.38 KB, patch)
2010-08-31 13:04 UTC, Dejan Sakelšak 		rejected Details | Review

Description Dejan Sakelšak 2010-08-31 13:03:11 UTC 
Created attachment 169159 [details] [review]
This patch fixes the header bug

flvmux genereates a bad header
Comment 1 Dejan Sakelšak 2010-08-31 13:04:42 UTC 
Created attachment 169160 [details] [review]
Fixes a bug of the previous patch

apply both patches
Comment 2 Tim-Philipp Müller 2010-08-31 13:29:13 UTC 
Could you provide a single clean patch and some explanation / commentary?

Also, please set your git committer name to a full and proper name.
Comment 3 Dejan Sakelšak 2010-08-31 14:06:30 UTC 
The difference between the produced header from flvmux and ffmux_flv, appeared like a bug. The problem lies in flvmux pushing the header buffer and the metadata tag buffer separately, which (if the sink uses an improperly written library) appears like an offset bug. 

The attached patch joins the buffers and pushes them together. 

Sorry for the inconvenience.