After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 628384 - PAM module cannot be built anymore
PAM module cannot be built anymore
Status: RESOLVED FIXED
Product: gnome-keyring
Classification: Core
Component: general
2.31.x
Other Linux
: Normal normal
: ---
Assigned To: GNOME keyring maintainer(s)
GNOME keyring maintainer(s)
Depends on:
Blocks:
 
 
Reported: 2010-08-31 00:03 UTC by Vincent Untz
Modified: 2010-08-31 22:30 UTC
See Also:
GNOME target: ---
GNOME version: ---


Description Vincent Untz 2010-08-31 00:03:13 UTC 
Commit 3b838fe2 makes it impossible to build the PAM module:

checking security/pam_modules.h usability... yes
checking security/pam_modules.h presence... yes
checking for security/pam_modules.h... yes
checking pam/pam_modules.h usability... no
checking pam/pam_modules.h presence... no
checking for pam/pam_modules.h... no
configure: error: The PAM headers are missing

This is because AC_CHECK_HEADERS is misused. The new code in configure.in is:
 AC_CHECK_HEADERS(security/pam_modules.h pam/pam_modules.h, have_pam=yes, have_pam=no)

And the autoconf doc states (http://www.gnu.org/software/hello/manual/autoconf/Generic-Headers.html):

For each given system header file header-file in the blank-separated argument list that exists, define HAVE_header-file (in all capitals). If action-if-found is given, it is additional shell code to execute when one of the header files is found. You can give it a value of ‘break’ to break out of the loop on the first match. If action-if-not-found is given, it is executed when one of the header files is not found.

So we will always get have_pam=no.
Comment 1 Götz Waschk 2010-08-31 07:26:17 UTC 
Indeed, the half-eaten fruit patch broke pam support.
Comment 2 Stef Walter 2010-08-31 22:30:05 UTC 
Sorry about that. I reopened the bug and reverted the patch:

https://bugzilla.gnome.org/show_bug.cgi?id=627422

commit 4ed44a48151706e57af32025332615320f7d18ff
Author: Stef Walter <stef@memberwebs.com>
Date:   Tue Aug 31 22:27:04 2010 +0000

    Revert "[pam] Fix build on Snow Leopard."
    
    This reverts commit dc9f71c5b77ea481e71cc7c250de4a967991b16a.
    
    Reverted due to: https://bugzilla.gnome.org/show_bug.cgi?id=628384