After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 628349 - [v4l2src] Doesn't support capturing mpegts using mmap
[v4l2src] Doesn't support capturing mpegts using mmap
Status: RESOLVED FIXED
Product: GStreamer
Classification: Platform
Component: gst-plugins-good
git master
Other Linux
: Normal normal
: 0.10.26
Assigned To: GStreamer Maintainers
GStreamer Maintainers
Depends on:
Blocks:
 
 
Reported: 2010-08-30 17:45 UTC by Sjoerd Simons
Modified: 2010-09-04 13:06 UTC
See Also:
GNOME target: ---
GNOME version: ---

Attachments
fix grabbing mpeg-ts over mmap (1.55 KB, patch)
2010-08-30 17:45 UTC, Sjoerd Simons 		committed Details | Review
Use GstBaseSrc::block-size as fallback size (untested as i don't have hardware that triggers this path) (853 bytes, patch)
2010-08-30 18:06 UTC, Sjoerd Simons 		committed Details | Review

Description Sjoerd Simons 2010-08-30 17:45:14 UTC 
Created attachment 169105 [details] [review]
fix grabbing mpeg-ts over mmap

Hey,

capturing mpeg-ts via the mmap interface because the result of the capture doesn't match the framesize v4l2src thinks it should have. Fixed in attached patch
Comment 1 Sjoerd Simons 2010-08-30 18:06:26 UTC 
Created attachment 169108 [details] [review]
Use GstBaseSrc::block-size as fallback size (untested as i don't have hardware that triggers this path)
Comment 2 Sebastian Dröge (slomo) 2010-08-31 08:19:36 UTC 
Will push both patches after release
Comment 3 Sebastian Dröge (slomo) 2010-09-04 13:06:13 UTC 
commit e9a30e454a583962ef981fa9846a2c60aca3480e
Author: Sjoerd Simons <sjoerd.simons@collabora.co.uk>
Date:   Mon Aug 30 19:03:52 2010 +0100

    v4l2src: Use GstBaseSrc::block-size as fallback size

commit 74d7521a7cf759264f3ee02902a81ae77a232de7
Author: Sjoerd Simons <sjoerd.simons@collabora.co.uk>
Date:   Mon Aug 30 18:36:54 2010 +0100

    v4l2src: Fix using mpegts via the mmap interface
    
    MPEG doesn't have a static size per frame, so don't pretend it has one
    and fail when capturing because it doesn't match. Instead mark the size
    as unknown and let the read frame grabbing method use a reasonable fallback
    value (assuming that's only for actual streaming formats)
    
    Fixes bug #628349.