After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 628198 - Miscellaneous property string fixes
Miscellaneous property string fixes
Status: RESOLVED FIXED
Product: gtk+
Classification: Platform
Component: .General
2.90.x
Other Linux
: Normal normal
: ---
Assigned To: gtk-bugs
gtk-bugs
Depends on:
Blocks:
 
 
Reported: 2010-08-28 15:56 UTC by Philip Withnall
Modified: 2010-08-29 18:17 UTC
See Also:
GNOME target: ---
GNOME version: ---

Attachments
Miscellaneous property string fixes (patch for gtk-2-22) (2.00 KB, patch)
2010-08-28 15:56 UTC, Philip Withnall 		committed Details | Review
Miscellaneous property string fixes (patch for master) (5.61 KB, patch)
2010-08-28 15:57 UTC, Philip Withnall 		committed Details | Review

Description Philip Withnall 2010-08-28 15:56:34 UTC 
Created attachment 168953 [details] [review]
Miscellaneous property string fixes (patch for gtk-2-22)

Patch attached which fixes some problems with translatable property strings.

 • Removes some extraneous "to"s
 • It's "associated with", not "associated to"
 • "layout" is a noun, "lay out" is the verb form
 • Other than that, fixes a couple of typos

If this is OK, it would be best to get it in before the string freeze on Monday.
Comment 1 Philip Withnall 2010-08-28 15:57:27 UTC 
Created attachment 168954 [details] [review]
Miscellaneous property string fixes (patch for master)
Comment 2 Javier Jardón (IRC: jjardon) 2010-08-29 16:24:29 UTC 
This is the first backtrace:

Program received signal SIGSEGV, Segmentation fault.
0x00007ffff57aa036 in IA__gdk_gc_set_rgb_fg_color (gc=0xffffffffe4154160, 
    color=0x7fffffffab00) at /build/buildd/gtk+2.0-2.21.6/gdk/gdkgc.c:1328
1328	/build/buildd/gtk+2.0-2.21.6/gdk/gdkgc.c: Aucun fichier ou dossier de ce type.
	in /build/buildd/gtk+2.0-2.21.6/gdk/gdkgc.c
(gdb) bt

+ Trace 223458

  • #0 IA__gdk_gc_set_rgb_fg_color
    at /build/buildd/gtk+2.0-2.21.6/gdk/gdkgc.c line 1328
  • #1 setup_gc_with_fg
    at nautilus-icon-container.c line 8643
  • #2 setup_label_gcs
    at nautilus-icon-container.c line 8692
  • #3 realize
    at nautilus-icon-container.c line 4178
  • #4 g_closure_invoke
    from /usr/lib/libgobject-2.0.so.0
  • #5 ??
    from /usr/lib/libgobject-2.0.so.0
  • #6 g_signal_emit_valist
    from /usr/lib/libgobject-2.0.so.0
  • #7 g_signal_emit
    from /usr/lib/libgobject-2.0.so.0
  • #8 IA__gtk_widget_realize
    at /build/buildd/gtk+2.0-2.21.6/gtk/gtkwidget.c line 3528
  • #9 IA__gtk_widget_map
    at /build/buildd/gtk+2.0-2.21.6/gtk/gtkwidget.c line 3402
  • #10 gtk_scrolled_window_forall
    at /build/buildd/gtk+2.0-2.21.6/gtk/gtkscrolledwindow.c line 1086
  • #11 gtk_container_map
    at /build/buildd/gtk+2.0-2.21.6/gtk/gtkcontainer.c line 2690
  • #12 g_closure_invoke
    from /usr/lib/libgobject-2.0.so.0
  • #13 ??
    from /usr/lib/libgobject-2.0.so.0
  • #14 g_signal_emit_valist
    from /usr/lib/libgobject-2.0.so.0
  • #15 g_signal_emit
    from /usr/lib/libgobject-2.0.so.0
  • #16 IA__gtk_widget_map
    at /build/buildd/gtk+2.0-2.21.6/gtk/gtkwidget.c line 3404
  • #17 gtk_box_forall
    at /build/buildd/gtk+2.0-2.21.6/gtk/gtkbox.c line 1251
  • #18 gtk_container_map
    at /build/buildd/gtk+2.0-2.21.6/gtk/gtkcontainer.c line 2690
  • #19 g_closure_invoke
    from /usr/lib/libgobject-2.0.so.0
  • #20 ??
    from /usr/lib/libgobject-2.0.so.0
  • #21 g_signal_emit_valist
    from /usr/lib/libgobject-2.0.so.0
  • #22 g_signal_emit
    from /usr/lib/libgobject-2.0.so.0
  • #23 IA__gtk_widget_map
    at /build/buildd/gtk+2.0-2.21.6/gtk/gtkwidget.c line 3404
  • #24 gtk_box_forall
    at /build/buildd/gtk+2.0-2.21.6/gtk/gtkbox.c line 1251
  • #25 gtk_container_map
    at /build/buildd/gtk+2.0-2.21.6/gtk/gtkcontainer.c line 2690
  • #26 g_closure_invoke
    from /usr/lib/libgobject-2.0.so.0
  • #27 ??
    from /usr/lib/libgobject-2.0.so.0
  • #28 g_signal_emit_valist
    from /usr/lib/libgobject-2.0.so.0
  • #29 g_signal_emit
    from /usr/lib/libgobject-2.0.so.0
  • #30 IA__gtk_widget_map
    at /build/buildd/gtk+2.0-2.21.6/gtk/gtkwidget.c line 3404
  • #31 gtk_notebook_map
    at /build/buildd/gtk+2.0-2.21.6/gtk/gtknotebook.c line 1747
  • #32 g_closure_invoke
    from /usr/lib/libgobject-2.0.so.0
  • #33 ??
    from /usr/lib/libgobject-2.0.so.0
  • #34 g_signal_emit_valist
    from /usr/lib/libgobject-2.0.so.0
  • #35 g_signal_emit
    from /usr/lib/libgobject-2.0.so.0
  • #36 IA__gtk_widget_map
    at /build/buildd/gtk+2.0-2.21.6/gtk/gtkwidget.c line 3404
  • #37 gtk_box_forall
    at /build/buildd/gtk+2.0-2.21.6/gtk/gtkbox.c line 1251
  • #38 gtk_container_map
    at /build/buildd/gtk+2.0-2.21.6/gtk/gtkcontainer.c line 2690
  • #39 g_closure_invoke
    from /usr/lib/libgobject-2.0.so.0
  • #40 ??
    from /usr/lib/libgobject-2.0.so.0
  • #41 g_signal_emit_valist
    from /usr/lib/libgobject-2.0.so.0
  • #42 g_signal_emit
    from /usr/lib/libgobject-2.0.so.0
  • #43 IA__gtk_widget_map
    at /build/buildd/gtk+2.0-2.21.6/gtk/gtkwidget.c line 3404 






Comment 3


Javier Jardón (IRC: jjardon)





          2010-08-29 16:26:38 UTC
        



This is the second:

Program received signal SIGSEGV, Segmentation fault.
0x00007ffff57aa036 in IA__gdk_gc_set_rgb_fg_color (gc=0xffffffffe4009330, 
    color=0x7fffffffcef0) at /build/buildd/gtk+2.0-2.21.6/gdk/gdkgc.c:1328
1328	/build/buildd/gtk+2.0-2.21.6/gdk/gdkgc.c: Aucun fichier ou dossier de ce type.
	in /build/buildd/gtk+2.0-2.21.6/gdk/gdkgc.c
(gdb) bt




+
Trace
    223460






    

  • 
#0
IA__gdk_gc_set_rgb_fg_color

    
                at /build/buildd/gtk+2.0-2.21.6/gdk/gdkgc.c
                  line
                  1328

    

    • 

  • 
#1
setup_gc_with_fg

    
                at nautilus-icon-container.c
                  line
                  8643

    

    • 

  • 
#2
setup_label_gcs

    
                at nautilus-icon-container.c
                  line
                  8692

    

    • 

  • 
#3
nautilus_icon_container_theme_changed

    
                at nautilus-icon-container.c
                  line
                  8907

    

    • 

  • 
#4
style_set

    
                at nautilus-icon-container.c
                  line
                  4235

    

    • 

  • 
#5
g_closure_invoke

    
                from
                /usr/lib/libgobject-2.0.so.0

    

    • 

  • 
#6
??

    
                from
                /usr/lib/libgobject-2.0.so.0

    

    • 

  • 
#7
g_signal_emit_valist

    
                from
                /usr/lib/libgobject-2.0.so.0

    

    • 

  • 
#8
g_signal_emit

    
                from
                /usr/lib/libgobject-2.0.so.0

    

    • 

  • 
#9
gtk_widget_set_style_internal

    
                at /build/buildd/gtk+2.0-2.21.6/gtk/gtkwidget.c
                  line
                  6961

    

    • 

  • 
#10
reset_rc_styles_recurse

    
                at /build/buildd/gtk+2.0-2.21.6/gtk/gtkwidget.c
                  line
                  7171

    

    • 

  • 
#11
gtk_scrolled_window_forall

    
                at /build/buildd/gtk+2.0-2.21.6/gtk/gtkscrolledwindow.c
                  line
                  1086

    

    • 

  • 
#12
gtk_box_forall

    
                at /build/buildd/gtk+2.0-2.21.6/gtk/gtkbox.c
                  line
                  1251

    

    • 

  • 
#13
gtk_box_forall

    
                at /build/buildd/gtk+2.0-2.21.6/gtk/gtkbox.c
                  line
                  1251

    

    • 

  • 
#14
gtk_box_forall

    
                at /build/buildd/gtk+2.0-2.21.6/gtk/gtkbox.c
                  line
                  1251

    

    • 

  • 
#15
gtk_table_forall

    
                at /build/buildd/gtk+2.0-2.21.6/gtk/gtktable.c
                  line
                  935

    

    • 

  • 
#16
gtk_rc_reset_widgets

    
                at /build/buildd/gtk+2.0-2.21.6/gtk/gtkrc.c
                  line
                  1668

    

    • 

  • 
#17
g_closure_invoke

    
                from
                /usr/lib/libgobject-2.0.so.0

    

    • 

  • 
#18
??

    
                from
                /usr/lib/libgobject-2.0.so.0

    

    • 

  • 
#19
g_signal_emit_valist

    
                from
                /usr/lib/libgobject-2.0.so.0

    

    • 

  • 
#20
g_signal_emit

    
                from
                /usr/lib/libgobject-2.0.so.0

    

    • 

  • 
#21
??

    
                from
                /usr/lib/libgobject-2.0.so.0

    

    • 

  • 
#22
??

    
                from
                /usr/lib/libgobject-2.0.so.0

    

    • 

  • 
#23
g_object_thaw_notify

    
                from
                /usr/lib/libgobject-2.0.so.0

    

    • 

  • 
#24
_gtk_settings_reset_rc_values

    
                at /build/buildd/gtk+2.0-2.21.6/gtk/gtksettings.c
                  line
                  2018

    

    • 

  • 
#25
IA__gtk_rc_reparse_all_for_settings

    
                at /build/buildd/gtk+2.0-2.21.6/gtk/gtkrc.c
                  line
                  1832

    

    • 

  • 
#26
gtk_rc_settings_changed

    
                at /build/buildd/gtk+2.0-2.21.6/gtk/gtkrc.c
                  line
                  682

    

    • 

  • 
#27
g_closure_invoke

    
                from
                /usr/lib/libgobject-2.0.so.0

    

    • 

  • 
#28
??

    
                from
                /usr/lib/libgobject-2.0.so.0

    

    • 

  • 
#29
g_signal_emit_valist

    
                from
                /usr/lib/libgobject-2.0.so.0

    

    • 

  • 
#30
g_signal_emit

    
                from
                /usr/lib/libgobject-2.0.so.0

    

    • 

  • 
#31
??

    
                from
                /usr/lib/libgobject-2.0.so.0

    

    • 

  • 
#32
g_object_notify

    
                from
                /usr/lib/libgobject-2.0.so.0

    

    • 

  • 
#33
_gtk_settings_handle_event

    
                at /build/buildd/gtk+2.0-2.21.6/gtk/gtksettings.c
                  line
                  1963

    

    • 

  • 
#34
IA__gtk_main_do_event

    
                at /build/buildd/gtk+2.0-2.21.6/gtk/gtkmain.c
                  line
                  1480

    

    • 

  • 
#35
gdk_event_dispatch

    
                at /build/buildd/gtk+2.0-2.21.6/gdk/x11/gdkevents-x11.c
                  line
                  2377

    

    • 

  • 
#36
g_main_context_dispatch

    
                from
                /lib/libglib-2.0.so.0

    

    • 

  • 
#37
??

    
                from
                /lib/libglib-2.0.so.0

    

    • 

  • 
#38
g_main_loop_run

    
                from
                /lib/libglib-2.0.so.0

    

    • 

  • 
#39
IA__gtk_main

    
                at /build/buildd/gtk+2.0-2.21.6/gtk/gtkmain.c
                  line
                  1237

    

    • 

  • 
#40
main

    
                at nautilus-main.c
                  line
                  544

    

    • 













Comment 4


Javier Jardón (IRC: jjardon)





          2010-08-29 16:58:55 UTC
        



Review of attachment 168953 [details] [review]:

looks good






Comment 5


Javier Jardón (IRC: jjardon)





          2010-08-29 16:59:07 UTC
        



Review of attachment 168954 [details] [review]:

looks good






Comment 6


Philip Withnall





          2010-08-29 18:02:59 UTC
        



Comment on attachment 168953 [details] [review]
Miscellaneous property string fixes (patch for gtk-2-22)

What are the backtraces for?






Comment 7


Philip Withnall





          2010-08-29 18:09:22 UTC
        



I'll send out a notification e-mail for these changes and the ones in bug #528257 shortly.

On master:

commit ba158a24fe150b6535b376d3ba2696d4eb581466
Author: Philip Withnall <philip@tecnocode.co.uk>
Date:   Sat Aug 28 13:51:41 2010 +0100

    Miscellaneous property string fixes

 gdk/gdkdevice.c        |   10 +++++-----
 gtk/gtkbbox.c          |    4 ++--
 gtk/gtktoolitemgroup.c |    2 +-
 3 files changed, 8 insertions(+), 8 deletions(-)

On gtk-2-22:

commit 77d28e31044c7792cb7982498eade7d80316b160
Author: Philip Withnall <philip@tecnocode.co.uk>
Date:   Sat Aug 28 16:55:53 2010 +0100

    Miscellaneous property string fixes

 gtk/gtkbbox.c          |    2 +-
 gtk/gtktoolitemgroup.c |    2 +-
 2 files changed, 2 insertions(+), 2 deletions(-)






Comment 8


Javier Jardón (IRC: jjardon)





          2010-08-29 18:17:36 UTC
        



(In reply to comment #6)
> (From update of attachment 168953 [details] [review])
> What are the backtraces for?

oh, forget them. These are for a different bug