GNOME Bugzilla – Bug 628131
error message when trying to link ICQ with jabber
Last modified: 2010-09-06 15:48:28 UTC
when I try to link an icq account with a jabber account I get following message: TelepathyBackend-Message: Failed to change contact's alias: Sadly, there's no general API in libpurple to set your own server alias. after that the merged contact has the alias from the jabber account, when I unlink now the icq account still has that alias and not the original one (which was the icq id only), until I restart empathy.
You can also achieve this (stomping all over aliases) by adding a linked Individual into a link in the linking dialogue, then adding a singleton Individual, then removing the linked Individual. Looks like my changes in http://git.gnome.org/browse/folks/commit/?id=c9afc15599021aa2b4a18ccd1563662c35290a3d were A Bad Idea.
Should we consider this as a folks bug?
Yes, both parts of the bugs will need fixing in folks. I don't think any Empathy changes will be necessary, but I'm not completely sure.
Created attachment 169099 [details] [review] Squashed diff of the 628131-alias-stomping branch http://git.collabora.co.uk/?p=user/pwith/folks;a=shortlog;h=refs/heads/628131-alias-stomping I'm hopeful that this will fix it. It's certainly the right thing to do, and I can no longer mess up Individuals' aliases by messing around in the linking dialogue, but I couldn't do it completely reliably before.
Review of attachment 169099 [details] [review]: Looks good. commit 5e414f6d922f0535c5699ecb89d00c1618ea4d5a Author: Philip Withnall <philip.withnall@collabora.co.uk> Date: Mon Aug 30 16:46:12 2010 +0100 Don't set Individual.alias when updating the alias from Personas Set the private Individual._alias member instead, to prevent the changed alias (which could be a fallback display ID or similar) from being pushed down to all the Personas and stomping all over their aliases. Helps: bgo#628131 folks/individual.vala | 12 +++++++++--- 1 files changed, 9 insertions(+), 3 deletions(-) commit 1f549b38b0b1edd0f352153de8b58711a2b594b3 Author: Philip Withnall <philip.withnall@collabora.co.uk> Date: Mon Aug 30 16:43:36 2010 +0100 Refactor Individual.update_alias() to give a single notification path folks/individual.vala | 48 +++++++++++++++++++++++------------------------- 1 files changed, 23 insertions(+), 25 deletions(-)
> TelepathyBackend-Message: Failed to change contact's alias: Sadly, there's no > general API in libpurple to set your own server alias. This hasn't been fixed yet.
(In reply to comment #6) > > TelepathyBackend-Message: Failed to change contact's alias: Sadly, there's no > > general API in libpurple to set your own server alias. > > This hasn't been fixed yet. Re-opening.
(In reply to comment #6) > > TelepathyBackend-Message: Failed to change contact's alias: Sadly, there's no > > general API in libpurple to set your own server alias. > > This hasn't been fixed yet. I can't see a way we could improve this, actually. Closing again.