GNOME Bugzilla – Bug 628005
Russian: evolution <Advanced Search> dialogs are oversized
Last modified: 2012-10-27 19:45:19 UTC
To reproduce <Advanced Search> dialog: 1. Run evolution in Russian language 2. Go To Search menu > Click Advanced Search Then Notice the issue (See attachment-fedora12_ru.png), compared with attachment-fedora12_eng.png, the <Advanced Search> dialog in ru was oversized.
Created attachment 168781 [details] fedora12_ru.png
Created attachment 168782 [details] fedora12_enu.png
Created attachment 168784 [details] [review] 628005.patch I created the patch in attachment. I just tried to move "Include threads" label with is combox to new line, so the UI in Russian may not be oversized in horizontal. Could you review if the patch is OK or you may have better way to fix it? If it is OK, please help to check-in the patch into master branch and then I will submit it to MeeGo branch to make these 2 branch be same. Thanks!
It would be better if the 'Add condition' button appears below 'Include threads' as its associated with tree view where the conditions are displayed. So the order would be, Find items: Include threads Add condition <Tree View> This patch cannot go into master as we are current under UI freeze. Please provide an updated patch and it would be committed once we branch master for evolution-2.32 release.
Review of attachment 168784 [details] [review]: marking as needs-work.
Though this is a UI change, it could be considered as a usability fix as well. Please attach the patch and I will inquire if its possible to absorb this patch for 2.32 release..
Created attachment 169031 [details] [review] 628005.patch Updated the patch to make the order be Find items: Include threads Add condition <Tree View> Could you check it? Thanks!
I would consider this as a usability fix. Added additional padding of 12 pixels to make the dialog look better and commit the patch to master branch. commit id - 252ed73211d3e89077a7718e857a11a6f41e4e05
Created attachment 169040 [details] screen shot from the final commit
We should turn the Search Folder Sources options into a combo box to free up more vertical space for the actual search conditions. The box looks pretty squished. Can be post-2.32.
So is there anything left here to fix? Current situation seems to be acceptable.
So I assume this is FIXED then. Please reopen if this is not the case.