After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 627946 - mp3parse misuses GST_FLOW_IS_FATAL, doesn't forward GST_FLOW_UNEXPECTED upstream
mp3parse misuses GST_FLOW_IS_FATAL, doesn't forward GST_FLOW_UNEXPECTED upstream
Status: RESOLVED FIXED
Product: GStreamer
Classification: Platform
Component: gst-plugins-ugly
git master
Other Mac OS
: Normal blocker
: 0.10.16
Assigned To: GStreamer Maintainers
GStreamer Maintainers
Depends on:
Blocks:
 
 
Reported: 2010-08-25 13:55 UTC by Alessandro Decina
Modified: 2010-08-25 15:36 UTC
See Also:
GNOME target: ---
GNOME version: ---

Attachments
fix (1.04 KB, patch)
2010-08-25 13:55 UTC, Alessandro Decina 		committed Details | Review

Description Alessandro Decina 2010-08-25 13:55:14 UTC 
Created attachment 168734 [details] [review]
fix

All in the subject. Patch attached.
Comment 1 Sebastian Dröge (slomo) 2010-08-25 14:11:31 UTC 
Comment on attachment 168734 [details] [review]
fix

Please push this, I'm going to make another pre-release later today
Comment 2 Sebastian Dröge (slomo) 2010-08-25 15:36:26 UTC 
commit 2ca354e3abbf5dc46a4a1a465b356e92ef18710d
Author: Alessandro Decina <alessandro.decina@collabora.co.uk>
Date:   Wed Aug 25 15:39:33 2010 +0200

    mp3parse: propagate flow errors upstream.
    
    Remove a wrong GST_FLOW_IS_FATAL call. When pushing fails, mp3parse should
    always return the error upstream.