After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 627945 - Cover art is not transferred to the ipod touch
Cover art is not transferred to the ipod touch
Status: RESOLVED FIXED
Product: banshee
Classification: Other
Component: Device - iPod
git master
Other Linux
: Normal normal
: 1.x
Assigned To: Banshee Maintainers
Banshee Maintainers
Depends on:
Blocks:
 
 
Reported: 2010-08-25 13:43 UTC by lorenzo
Modified: 2010-08-29 22:50 UTC
See Also:
GNOME target: ---
GNOME version: ---

Attachments
Debug output (103.48 KB, application/zip)
2010-08-25 13:44 UTC, lorenzo 		  Details
Set cover art if available. (7.64 KB, patch)
2010-08-29 21:37 UTC, Jensen Somers 		none Details | Review
Add cover art if available. (2.59 KB, patch)
2010-08-29 21:53 UTC, Jensen Somers 		none Details | Review

Description lorenzo 2010-08-25 13:43:01 UTC 
Dunno if this issue is related to banshee or not but if I copy an album to my ipod touch (1st gen - 3.1.3 - JB) everything goes smoothly but cover art is not displayed on the ipod. (still I cannot understand if it's trasferred but not displayed...)
See attached the debug log.
Thanks
Lorenzo
Comment 1 lorenzo 2010-08-25 13:44:30 UTC 
Created attachment 168732 [details]
Debug output
Comment 2 Jensen Somers 2010-08-29 21:37:12 UTC 
Created attachment 169017 [details] [review]
Set cover art if available.

It seems that cover art was not yet copied to the device when implementing the new libgpod bindings.

As far as I can tell libgpod handles existing cover art and removal so it should be sufficient to simply set it.
Comment 3 Christophe Fergeau 2010-08-29 21:46:51 UTC 
You want to handle artwork removal too, for cases when there is initially album art on the ipod and the user removes it from banshee.
Comment 4 Jensen Somers 2010-08-29 21:53:22 UTC 
Created attachment 169019 [details] [review]
Add cover art if available.

Attached is a better patch which does not mess with the other parts of the code and calls ThumbnailsRemoveAll() when the cover art does not exist.
Comment 5 lorenzo 2010-08-29 22:03:32 UTC 
Thank you all. Will the patch be soon available in the banshee git repository? Greetings. Is there something more I can do to help you (testing the patch for example..)?
Lorenzo
Comment 6 Alan McGovern 2010-08-29 22:50:54 UTC 
I reviewed and tested the patch and it worked perfectly for me. Committed to git.