After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 627881 - dbus assertion failure while browsing in Nautilus
dbus assertion failure while browsing in Nautilus
Status: RESOLVED FIXED
Product: gvfs
Classification: Core
Component: metadata
1.6.x
Other Solaris
: Normal normal
: ---
Assigned To: gvfs-maint
gvfs-maint
Depends on:
Blocks:
 
 
Reported: 2010-08-24 19:50 UTC by Jonathan Blanchard
Modified: 2011-03-16 15:15 UTC
See Also:
GNOME target: ---
GNOME version: ---


Attachments
Stacktrace from the failing thread (5.35 KB, text/plain)
2010-08-24 19:50 UTC, Jonathan Blanchard
  Details
Same as above with correct mime type (5.35 KB, text/plain)
2010-08-24 19:55 UTC, Jonathan Blanchard
  Details
trivial patch (505 bytes, patch)
2010-09-09 04:43 UTC, Jonathan Blanchard
committed Details | Review

Description Jonathan Blanchard 2010-08-24 19:50:33 UTC
Created attachment 168678 [details]
Stacktrace from the failing thread

While browsing randomly in Nautilus it sometimes close suddenly following an assertion check failure from D-Bus. See attached stack trace for details.

Failure happens while browsing directories in no particular pattern. Always happen if browsing long enough. It does not appear to be linked to a particular directory or file type. Moreover, it won't happen when leaving Nautilus idle.

The filename at line 211 of the stacktrace currently being "/tmp" was different every time I reproduced the bug and do not appear to be linked to the location I was viewing with Nautilus.


Env details :

Solaris 10 U8 x86
Compiler gcc 4.3.4

gvfs 1.6.3
glib 2.24.2
dbus 1.2.24
nautilus 2.30.1
Comment 1 Jonathan Blanchard 2010-08-24 19:55:03 UTC
Created attachment 168679 [details]
Same as above with correct mime type
Comment 2 Jonathan Blanchard 2010-09-09 04:43:41 UTC
Created attachment 169824 [details] [review]
trivial patch

Trivial patch to fix the described issue.
Comment 3 Matthias Clasen 2010-09-09 20:34:27 UTC
Review of attachment 169824 [details] [review]:

That looks obviously correct.
Comment 4 André Klapper 2011-01-22 14:21:41 UTC
Jonathan: If the patch still applies, can you commit it, or don't you have commit rights?
Comment 5 Jonathan Blanchard 2011-01-22 14:49:19 UTC
I do not have commit rights, sorry. The patch does apply with gvfs 1.6.6, I did not check 1.7.x though.
Comment 6 Tomas Bzatek 2011-03-16 15:15:05 UTC
Fixed in master, thanks for spotting this.

commit 5fb862503052a1c130121c4005bd7ff0a183ee43
Author: Jonathan Blanchard <BlanchardJ@ieee.org>
Date:   Wed Mar 16 16:11:20 2011 +0100

    client: Fix wrong assignment before dbus_connection_unref()
    
    https://bugzilla.gnome.org/show_bug.cgi?id=627881