After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 627828 - Drag and drop between treeviews in different window groups broken: gtk_window_group_remove_window: assertion `window->group == window_group' failed
Drag and drop between treeviews in different window groups broken: gtk_window...
Status: RESOLVED FIXED
Product: gtk+
Classification: Platform
Component: Widget: Other
2.90.x
Other Linux
: Normal major
: ---
Assigned To: gtk-bugs
gtk-bugs
Depends on:
Blocks:
 
 
Reported: 2010-08-24 11:00 UTC by Philip Withnall
Modified: 2010-08-24 14:17 UTC
See Also:
GNOME target: ---
GNOME version: ---


Attachments
gtk/gtkdnd.c: Fix drag and drop between tree views in different window groups (981 bytes, patch)
2010-08-24 11:01 UTC, Philip Withnall
none Details | Review

Description Philip Withnall 2010-08-24 11:00:03 UTC
Dragging a row between treeviews in different window groups (e.g. in different windows) was broken by commit 50aec80efbbae45f9736dc07160e7e767188d542.

On dropping a row, the following warning is now produced, and the drag and drop operation fails:

gtk_window_group_remove_window: assertion `window->group == window_group' failed

This is because gtk_window_get_group() never returns NULL; if the window doesn't have a group, the default group is returned.

Patch attached which adds a check in gtkdnd.c to see if the group is the default group. It's a tiny bit hacky, but any better fix would require API additions.
Comment 1 Philip Withnall 2010-08-24 11:01:58 UTC
Created attachment 168630 [details] [review]
gtk/gtkdnd.c: Fix drag and drop between tree views in different window groups
Comment 2 Javier Jardón (IRC: jjardon) 2010-08-24 14:16:07 UTC
Yeah, you are right. THis an other similar problems was fixed in commit ccae84208954cb3b37e91a64058ca801791e853a

Thank you for your bug report.
Comment 3 Javier Jardón (IRC: jjardon) 2010-08-24 14:17:56 UTC
Sorry, the correct commit is this:
http://git.gnome.org/browse/gtk+/commit/?id=c05f344c0a5c7bd1096dd7bd10c99a0e585826d2