GNOME Bugzilla – Bug 627706
Use the Individual.personas_changed signal
Last modified: 2010-08-30 09:32:36 UTC
Empathy should be ported to use the FolksIndividual::personas-changed signal introduced in bug #626725, which allows more efficient notification of changes to the set of Personas in an Individual. Branch appearing soon.
Created attachment 168553 [details] [review] Squashed diff of the 627706-personas-changed branch http://git.collabora.co.uk/?p=user/pwith/empathy;a=shortlog;h=refs/heads/627706-personas-changed
Review of attachment 168553 [details] [review]: Branch looks good. Feel free to merge once the folks branch has been merged and released. Don't forget to bump the folks dep in configure.ac. ::: libempathy-gtk/empathy-individual-widget.c @@ +1739,3 @@ } + /* Update individual table *//* TODO */ That's not a regression introduced by this patch right? If not open a bug.
(In reply to comment #2) > That's not a regression introduced by this patch right? If not open a bug. That was an outdated note to myself which I forgot to remove. However, when testing the branch before merging, it appears to have broken slightly with all the recent changes in folks and Empathy. I'll rework it later.
Created attachment 168879 [details] [review] Squashed diff of the 627706-personas-changed-rebase1 branch This removes that faulty comment, fixes calculation of new_num_personas and fixes a few faulty checks which were causing problems in the linking dialogue. http://git.collabora.co.uk/?p=user/pwith/empathy;a=shortlog;h=refs/heads/627706-personas-changed-rebase1
commit 49d599a212783c30d25200a1ef8435e252c6d113 Author: Philip Withnall <philip.withnall@collabora.co.uk> Date: Fri Aug 27 14:34:39 2010 +0100 Fix calculation of the number of new personas in EmpathyIndividualWidget libempathy-gtk/empathy-individual-widget.c | 9 +++++++-- 1 files changed, 7 insertions(+), 2 deletions(-) commit 7b5ebcfc1c2e69d18bd105932a3d3c792832fd02 Author: Philip Withnall <philip.withnall@collabora.co.uk> Date: Mon Aug 23 11:41:48 2010 +0100 Port EmpathyPersonaStore to use Individual.personas_changed This makes the notification of changed Personas a lot more efficient in the store. Closes: bgo#627706 libempathy-gtk/empathy-persona-store.c | 44 ++++++++------------------------ 1 files changed, 11 insertions(+), 33 deletions(-) commit 46aed27859fd6732b2564898135c7c36dcdb28b0 Author: Philip Withnall <philip.withnall@collabora.co.uk> Date: Mon Aug 23 11:32:22 2010 +0100 Port EmpathyIndividualWidget to use Individual.personas_changed This makes the notification of changed Personas a lot more efficient in the widget. Helps: bgo#627706 libempathy-gtk/empathy-individual-widget.c | 119 ++++++++++++++-------------- 1 files changed, 61 insertions(+), 58 deletions(-)