After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 626992 - Back and Forward buttons in Previous conservations window are reversed
Back and Forward buttons in Previous conservations window are reversed
Status: RESOLVED FIXED
Product: empathy
Classification: Core
Component: Archives
2.31.x
Other Linux
: Normal normal
: ---
Assigned To: empathy-maint
Depends on:
Blocks:
 
 
Reported: 2010-08-15 21:22 UTC by Vish
Modified: 2010-08-16 09:05 UTC
See Also:
GNOME target: ---
GNOME version: ---


Attachments
Flipped Buttons. (3.41 KB, image/png)
2010-08-15 21:23 UTC, Vish
  Details
http://git.Collabora.co.uk/?p=user/cassidy/empathy;a=shortlog;h=refs/heads/next-button-626992 (9.88 KB, patch)
2010-08-16 08:19 UTC, Guillaume Desmottes
none Details | Review
http://git.Collabora.co.uk/?p=user/cassidy/empathy;a=shortlog;h=refs/heads/next-button-626992 (2.34 KB, patch)
2010-08-16 08:32 UTC, Guillaume Desmottes
none Details | Review

Description Vish 2010-08-15 21:22:25 UTC
Bug also reported in lp:
https://bugs.launchpad.net/ubuntu/+source/empathy/+bug/618391

In the empathy Previous Conversations window ,Back and Forward Buttons are switched as Forward and Back
Usually within empathy and elsewhere in the system,
Back is on the left side and Forward is on the right , but in this window it has been switched.

Attaching screenshot of the problem

Also to note is that the buttons do not have a consistent padding as mentioned in the HIG:
"12 pixels of padding to either side of centered text (and any accompanying graphic). If appearing in a group of buttons, longest button label sets button size, center all other button labels and accompanying graphics in same-sized buttons"
http://library.gnome.org/devel/hig-book/stable/design-text-labels.html.en#layout-label-position
[I guess we can fix the padding issue in the same bug itself?]
Comment 1 Vish 2010-08-15 21:23:01 UTC
Created attachment 167916 [details]
Flipped Buttons.
Comment 2 Guillaume Desmottes 2010-08-16 08:19:39 UTC
Created attachment 167936 [details] [review]
http://git.Collabora.co.uk/?p=user/cassidy/empathy;a=shortlog;h=refs/heads/next-button-626992

 libempathy-gtk/empathy-log-window.ui |   58 +++++++++++++++++++++------------
 1 files changed, 37 insertions(+), 21 deletions(-)
Comment 3 Guillaume Desmottes 2010-08-16 08:24:15 UTC
This problem has been fixed in the development version. The fix will be available in the next major software release. Thank you for your bug report.
Comment 4 Guillaume Desmottes 2010-08-16 08:32:17 UTC
Created attachment 167937 [details] [review]
http://git.Collabora.co.uk/?p=user/cassidy/empathy;a=shortlog;h=refs/heads/next-button-626992

 libempathy-gtk/empathy-log-window.ui |   16 ++++++++++++----
 1 files changed, 12 insertions(+), 4 deletions(-)
Comment 5 Vish 2010-08-16 09:05:58 UTC
(In reply to comment #3)
> This problem has been fixed in the development version. The fix will be
> available in the next major software release. Thank you for your bug report.

Wow! that was a blaaaaazingly fast fix! Thanks! :)