After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 626952 - libnotify.pc: Requires should be Requires.private
libnotify.pc: Requires should be Requires.private
Status: RESOLVED WONTFIX
Product: libnotify
Classification: Platform
Component: general
git master
Other All
: Normal minor
: ---
Assigned To: William Jon McCann
: 656476 (view as bug list)
Depends on:
Blocks:
 
 
Reported: 2010-08-14 20:20 UTC by Michał Górny
Modified: 2011-08-19 06:46 UTC
See Also:
GNOME target: ---
GNOME version: ---

Attachments
Patch against the git HEAD (898 bytes, patch)
2010-08-14 20:26 UTC, Michał Górny 		none Details | Review

Description Michał Górny 2010-08-14 20:20:23 UTC 
Currently, libnotify's pkg-config file specifies a lot of dependant library packages in 'Requires'. This means that each application being linked against libnotify has to be linked against all of them which isn't true. In fact, such an app works completely fine with just '-lnotify'.

The pkg-config manpage clearly states that:
'The difference from Requires is that the packages listed under Requires.private are not taken into account when a flag list is computed for dynamically linked executable (i.e., when --static was not specified). In the situation where each .pc file corresponds to a library, Requires.private shall be used exclusively to specify the dependencies between the libraries.'

Thus, I think that all current 'Requires' of libnotify should be specified as 'Requires.private'.
Comment 1 Michał Górny 2010-08-14 20:26:35 UTC 
Created attachment 167887 [details] [review]
Patch against the git HEAD
Comment 2 Matthias Clasen 2011-05-03 17:54:41 UTC 
not really, it just has gdk-pixbuf, glib and gio in the Requires line nowadays.

gdk-pixbuf is needed, since we use it in the public api, and glib and gio are dependencies of gdk-pixbuf anyway.
Comment 3 Michał Górny 2011-08-13 21:39:59 UTC 
*** Bug 656476 has been marked as a duplicate of this bug. ***
Comment 4 Michał Górny 2011-08-13 21:41:54 UTC 
Still, glib & gio should not be directly linked.
Comment 5 David King 2011-08-19 06:46:28 UTC 
GLib is also used in the public API (at least GVariant, GList and GError), so the only candidate for moving to Requires.private is GIO.