After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 626876 - Port Gallery export to GtkBuilder
Port Gallery export to GtkBuilder
Status: RESOLVED FIXED
Product: f-spot
Classification: Other
Component: Export
GIT
Other Linux
: Normal normal
: 0.7.3
Assigned To: F-spot maintainers
F-spot maintainers
Depends on:
Blocks: f-spot-glade
 
 
Reported: 2010-08-13 20:18 UTC by Paul Lange
Modified: 2010-09-08 16:54 UTC
See Also:
GNOME target: ---
GNOME version: ---

Attachments
Create a file for each Gallery export class (40.32 KB, patch)
2010-08-13 20:25 UTC, Paul Lange 		committed Details | Review
FIX POTFILES.in. (2.20 KB, patch)
2010-08-17 12:12 UTC, Ruben Vermeersch 		committed Details | Review
Port Gallery export to GtkBuilder (98.38 KB, patch)
2010-08-17 13:25 UTC, Paul Lange 		committed Details | Review
Fixup creation of OptionMenus (2.10 KB, patch)
2010-08-17 23:07 UTC, Paul Lange 		committed Details | Review

Description Paul Lange 2010-08-13 20:18:13 UTC 
Port Gallery export to GtkBuilder
Comment 1 Paul Lange 2010-08-13 20:25:51 UTC 
Created attachment 167841 [details] [review]
Create a file for each Gallery export class
Comment 2 Paul Lange 2010-08-13 20:27:02 UTC 
This is only a first patch to make it easier to review. Nothing functional changed so far.
Comment 3 Ruben Vermeersch 2010-08-17 12:12:07 UTC 
Created attachment 168060 [details] [review]
FIX POTFILES.in.
Comment 4 Ruben Vermeersch 2010-08-17 12:12:59 UTC 
Keep in mind that you need to adjust po/POTFILES.in as well. You can test if this is needed by running "make check" in the po folder. This matters for the translators.
Comment 5 Ruben Vermeersch 2010-08-17 12:15:24 UTC 
Attachment 167841 [details] pushed as 0530d30 - Create a file for each Gallery export class


I've pushed this commit (not very much you can do wrong here). One thing to note is that the top lines of those files look a bit messy: tons of "using" statements, which are immediately followed by the namespace declaration. I prefer a blank line between those and the unneeded "using" statements should probably be removed. This is Monodevelop's fault though, so I'm not going to hold that against you :-).

Good work!
Comment 6 Paul Lange 2010-08-17 13:25:58 UTC 
Created attachment 168072 [details] [review]
Port Gallery export to GtkBuilder
Comment 7 Ruben Vermeersch 2010-08-17 13:33:07 UTC 
Attachment 168072 [details] pushed as 02c665f - Port Gallery export to GtkBuilder


Quality, thanks!
Comment 8 Paul Lange 2010-08-17 23:07:36 UTC 
Created attachment 168155 [details] [review]
Fixup creation of OptionMenus
Comment 9 Ruben Vermeersch 2010-08-24 10:34:08 UTC 
Attachment 168155 [details] pushed as 8428f16 - Fixup creation of OptionMenus


Merged!