After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 626841 - Add test-case for non-socket GIOStream
Add test-case for non-socket GIOStream
Status: RESOLVED FIXED
Product: glib
Classification: Platform
Component: gdbus
unspecified
Other Linux
: Normal normal
: ---
Assigned To: David Zeuthen (not reading bugmail)
gtkdev
Depends on:
Blocks:
 
 
Reported: 2010-08-13 14:02 UTC by David Zeuthen (not reading bugmail)
Modified: 2010-08-13 18:08 UTC
See Also:
GNOME target: ---
GNOME version: ---



Description David Zeuthen (not reading bugmail) 2010-08-13 14:02:53 UTC
Would probably be fine to just use a GIOStream from FDs returned by pipe(2). Pointed out on gtk-devel-list:

On Fri, Aug 13, 2010 at 8:18 AM, Michael Meeks <michael.meeks@novell.com> wrote:
> Good morning :-)
>
>        Looking forward to your arrival; thanks for writing the test case -
> rather useful :-)
>
>        Digging into the code some more, I'm a tad confused about the
> write_message code; looks like it should crash to me with a GIOStream
> that is not a GSocketConnection - ie. worker->socket will be NULL, and
> we crash in write_message. I assume gdbusprivate.c:~832 should be:
>
>        if (worker->socket != NULL) ?
Comment 1 David Zeuthen (not reading bugmail) 2010-08-13 18:08:07 UTC
Fixed with this commit

http://git.gnome.org/browse/glib/commit/?id=d344ff9d67a7e723a1c2163e7d9254dd6ef049d2