After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 626619 - [imagefreeze] Incorrect seek behaviour
[imagefreeze] Incorrect seek behaviour
Status: RESOLVED FIXED
Product: GStreamer
Classification: Platform
Component: gst-plugins-good
unspecified
Other Linux
: Normal normal
: 0.10.25
Assigned To: GStreamer Maintainers
GStreamer Maintainers
Depends on:
Blocks:
 
 
Reported: 2010-08-11 11:21 UTC by Brandon Lewis
Modified: 2010-08-12 09:30 UTC
See Also:
GNOME target: ---
GNOME version: ---


Attachments
Test Script (1.47 KB, text/x-python)
2010-08-11 11:22 UTC, Brandon Lewis
  Details
.jpg files used to test the script (557.49 KB, application/x-gzip)
2010-08-11 11:24 UTC, Brandon Lewis
  Details
imagefreeze: Send close segments when seeking only for non-flushing seeks and if we already sent a newsegment event (3.34 KB, patch)
2010-08-11 20:21 UTC, Sebastian Dröge (slomo)
committed Details | Review

Description Brandon Lewis 2010-08-11 11:21:08 UTC
The test case here is a simple slide-show in which a series of still images is added to a timeline and each one has a duration of 5 seconds. Only the first image actually appears for 5 seconds. All the rest flash by in a fraction of a second.
Comment 1 Brandon Lewis 2010-08-11 11:22:02 UTC
Created attachment 167581 [details]
Test Script

Pass in an arbitrary number of image files on the timeline.
Comment 2 Brandon Lewis 2010-08-11 11:24:39 UTC
Created attachment 167582 [details]
.jpg files used to test the script
Comment 3 Sebastian Dröge (slomo) 2010-08-11 16:43:47 UTC
Ok, that's definitely a gnonlin bug. There's a new imagefreeze instance for every picture and it gets seeks from 0 to 5s... and is then outputting buffers with ts from 0 to 5s.

gnonlin has to adjust the timestamps or segments somewhere.
Comment 4 Sebastian Dröge (slomo) 2010-08-11 20:21:06 UTC
Created attachment 167664 [details] [review]
imagefreeze: Send close segments when seeking only for non-flushing seeks and if we already sent a newsegment event

Fixes bug #626619.
Comment 5 Tim-Philipp Müller 2010-08-12 08:49:47 UTC
Comment on attachment 167664 [details] [review]
imagefreeze: Send close segments when seeking only for non-flushing seeks and if we already sent a newsegment event

>+      gboolean flush;
>
>+      flush = (flags & GST_SEEK_FLAG_FLUSH);

Would be nicer to make this a proper bool IMHO.
Comment 6 Sebastian Dröge (slomo) 2010-08-12 09:30:35 UTC
commit 90f273b165a6dc8429b96b7f8885d076ca6828ba
Author: Sebastian Dröge <sebastian.droege@collabora.co.uk>
Date:   Wed Aug 11 22:20:25 2010 +0200

    imagefreeze: Send close segments when seeking only for non-flushing seeks and if we already sent a
    
    Fixes bug #626619.