After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 626489 - Inspecting an element when the inspector is attached shows an empty window
Inspecting an element when the inspector is attached shows an empty window
Status: RESOLVED FIXED
Product: epiphany
Classification: Core
Component: Interface
unspecified
Other Linux
: Normal normal
: ---
Assigned To: Epiphany Maintainers
Epiphany Maintainers
Depends on:
Blocks:
 
 
Reported: 2010-08-09 21:53 UTC by Gustavo Noronha (kov)
Modified: 2010-08-24 19:14 UTC
See Also:
GNOME target: ---
GNOME version: ---


Attachments
proposed fix (3.68 KB, patch)
2010-08-09 21:56 UTC, Gustavo Noronha (kov)
committed Details | Review

Description Gustavo Noronha (kov) 2010-08-09 21:53:39 UTC
The inspector window is shown unconditionaly when the inspector requests being shown, this causes the window that holds it to be shown when inspecting something with the inspector already attached.
Comment 1 Gustavo Noronha (kov) 2010-08-09 21:56:12 UTC
Created attachment 167462 [details] [review]
proposed fix
Comment 2 Xan Lopez 2010-08-22 07:48:31 UTC
Comment on attachment 167462 [details] [review]
proposed fix

OK. I wonder if it would make more sense to just create/destroy the window on demand instead of have it floating around with a boolean indicating our state...
Comment 3 Gustavo Noronha (kov) 2010-08-24 19:14:38 UTC
Comment on attachment 167462 [details] [review]
proposed fix

That's a good point, I'll see if that simplifies the code, and follow up, thanks!