After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 626334 - When searching, message "0 found in this page" is misleading
When searching, message "0 found in this page" is misleading
Status: RESOLVED FIXED
Product: evince
Classification: Core
Component: general
git master
Other Linux
: Normal normal
: ---
Assigned To: Evince Maintainers
Evince Maintainers
Depends on:
Blocks:
 
 
Reported: 2010-08-07 20:29 UTC by José Aliste
Modified: 2010-08-14 09:01 UTC
See Also:
GNOME target: ---
GNOME version: ---

Attachments
Proposed patch (1.12 KB, patch)
2010-08-07 21:12 UTC, José Aliste 		needs-work Details | Review

Description José Aliste 2010-08-07 20:29:43 UTC 
Due to the fact that the search in Evince is "search as you type", the message "0 found in this page" only appears when there are no search results (in any page) the "in this page" may mislead the user to think there are results in other pages, when they are not.

I propose that we change the message to "no hits found" or something like this.
Comment 1 José Aliste 2010-08-07 21:12:08 UTC 
Created attachment 167347 [details] [review]
Proposed patch

patch adding "phrase not found" string when there are no results.
Comment 2 Carlos Garcia Campos 2010-08-14 08:48:00 UTC 
Review of attachment 167347 [details] [review]:

::: shell/ev-window.c
@@ +4867,3 @@
 				      contains plural cases. */
+		if (n_results == 0) {
+			/* if n_results == 0, then there are no results in any page. */

This assumption is wrong, ev_job_find_get_n_results() returns the number of results in the given page, so there might be results in other pages. I agree that when find job finishes and there aren't results in any page the message "0 found on this page" is confusing, it could be just "Not found"
Comment 3 Carlos Garcia Campos 2010-08-14 09:01:37 UTC 
I've just pushed a different patch to git master. Thanks!