GNOME Bugzilla – Bug 625960
Merge GSOC2009 work (sudoku-tube branch)
Last modified: 2013-11-07 18:39:06 UTC
I'm opening this bugreport as requested by Robert Ancell to track the progress merging the work to add telepathy tubes to gnome-sudoku. What still needs to be done: - Make the structural changes apply to master without the networking support - this patch should be easy to review and apply - Make a patch that adds the new network functionality (requires UI review etc)
I have committed my first work to a new branch "applygsoc2009" in gnome-games: http://git.gnome.org/browse/gnome-games/log/?h=applygsoc2009 Unfortunately I have not been able to build gnome-games with jhbuild and therefore I have not been able to test it but for sure it won't work as I went patch by patch trying to apply changes blindly. CC libgames_support_gi_la-eggdesktopfile.lo CC libgames_support_gi_la-eggsmclient-xsmp.lo CC libgames_support_gi_la-games-marshal.lo CCLD libgames-support-gi.la GEN GnomeGamesSupport-1.0.gir /home/pablo/opt/gnome2/share/gir-1.0/Gtk-2.0.gir: Incompatible version 1.1 (supported: 1.2) make[3]: *** [GnomeGamesSupport-1.0.gir] Error 1 make[3]: Leaving directory `/home/pablo/gnome-git/gnome-games/libgames-support' make[2]: *** [all] Error 2 make[2]: Leaving directory `/home/pablo/gnome-git/gnome-games/libgames-support' make[1]: *** [all-recursive] Error 1 make[1]: Leaving directory `/home/pablo/gnome-git/gnome-games' make: *** [all] Error 2 And gtk+ 2.22 needs some changes to adapt the code to latest gobject-introspection as it doesn't accept --strip-prefix parameter anymore. Removing it causes namespace conflicts. It's over me.
OK, I have been able to compile it just disabling introspection (--enable-introspection=no) I continue working on it. I will notify here when a working patch is ready.
I need some help... Zhang replaced the dialog_swaller hack and now it just creates a SudokuView instance (derives from gtk.AspectFrame) and adds it to the main_grid_container (see http://git.gnome.org/browse/gnome-games/tree/gnome-sudoku/src/lib/main.py?h=sudoku-tube#n243) In master, the main_grid_container is used by the game_selector and the SudokuGameDisplay (which was splitted in to SudokuView and SudokuModel). What's the best way to combine it? Any clue? I'm a bit lost. Also subscribing Zhang...
Any luck Pablo? Sorry, I don't know enough about the sudoku internals to help out.
(In reply to comment #4) > Any luck Pablo? Sorry, I don't know enough about the sudoku internals to help > out. No news. I have started lessons again and I don't have too much time :( Other options are going back and use dialog_swaller again or just make a patch with the changes to add multiplayer support delaying the refactoring part.
Sorry about the lack of feedback, I'll see if I can find some time to look at it this weekend.