After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 625336 - Crash when saving Tag Icon
Crash when saving Tag Icon
Status: RESOLVED FIXED
Product: f-spot
Classification: Other
Component: General
GIT
Other Linux
: Normal normal
: 0.7.2
Assigned To: F-spot maintainers
F-spot maintainers
Depends on:
Blocks:
 
 
Reported: 2010-07-26 16:41 UTC by Paul Wellner Bou
Modified: 2010-08-02 13:41 UTC
See Also:
GNOME target: ---
GNOME version: ---


Attachments
Don't BeginTransaction if it shouldn't and won't be committed (930 bytes, patch)
2010-07-28 12:31 UTC, Paul Wellner Bou
none Details | Review
Don't BeginTransaction if it shouldn't and won't be committed (931 bytes, patch)
2010-07-28 13:42 UTC, Paul Wellner Bou
committed Details | Review

Description Paul Wellner Bou 2010-07-26 16:41:34 UTC
I have a tag without any Icon because of previous bugs. So I tried to assign an Icon to this Tag, as without Icon it is not visible that this tag was assigned to the photos (in the browser window).

Right click on the tag, "Edit Tag", assign any Icon to it. Seems to work, but is not saved anywhere.

It does not seem to be committed until I modify any other tag of any photo. Then F-Spot crashes:

Exception in Gtk# callback delegate
  Note: Applications can use GLib.ExceptionManager.UnhandledException to handle the exception.
System.Exception: Can't start a recursive transaction
  at Hyena.Data.Sqlite.HyenaSqliteConnection.BeginTransaction () [0x0009e] in /usr/src/f-spot/lib/Hyena/Hyena.Data.Sqlite/Hyena.Data.Sqlite/HyenaSqliteConnection.cs:265 
  at Db.BeginTransaction () [0x00000] in /usr/src/f-spot/src/Db.cs:273 
  at FSpot.MainWindow.HandleTagEntryTagsAttached (System.Object o, System.String[] new_tags) [0x00060] in /usr/src/f-spot/src/MainWindow.cs:2888 
  at FSpot.Widgets.TagEntry.OnActivated () [0x00090] in /usr/src/f-spot/src/Widgets/TagEntry.cs:261 
  at Gtk.Entry.activated_cb (IntPtr entry) [0x00000] 
   at GLib.ExceptionManager.RaiseUnhandledException(System.Exception e, Boolean is_terminal)
   at Gtk.Entry.activated_cb(IntPtr entry)
   at Gtk.Application.gtk_main()
   at Gtk.Application.Run()
   at FSpot.Driver.Startup() in /usr/src/f-spot/src/main.cs:line 355
   at Hyena.Gui.CleanRoomStartup.Startup(Hyena.Gui.StartupInvocationHandler startup) in /usr/src/f-spot/lib/Hyena/Hyena.Gui/Hyena.Gui/CleanRoomStartup.cs:line 54
   at FSpot.Driver.Main(System.String[] args) in /usr/src/f-spot/src/main.cs:line 272
Comment 1 Paul Wellner Bou 2010-07-28 12:31:17 UTC
Created attachment 166700 [details] [review]
Don't BeginTransaction if it shouldn't and won't be committed
Comment 2 Paul Wellner Bou 2010-07-28 13:42:25 UTC
Created attachment 166712 [details] [review]
Don't BeginTransaction if it shouldn't and won't be committed
Comment 3 Ruben Vermeersch 2010-08-02 13:41:30 UTC
Attachment 166712 [details] pushed as c69c044 - Don't BeginTransaction if it shouldn't and won't be committed