Created attachment 166429 [details] [review]
Don't use deprecated GDK drawing APIs

Just a question: should intends be tab or spaces? Looks like many "-" rows was tab and replaced by spaces.

I don't care at all about tabs vs spaces, because I'm contributing to so many different projects that all have different ideas about it that I wouldn't get anything done due to reformatting...
I just know that my vimrc ontains "set expandtab", so in allt he code I write tabs get replaced by spaces automatically.

So if you need a space vs tabs replacement you probably need to do it manually before applying the patch.

Didn't mean to offend you, just asking because I self make patches and just wanted to know if there was a standard so I can do the right formatting.

Sorry if it sounded like I was offended, I'm a bit sensitive to that topic.
Lots of projects have different ideas about tabs vs spaces, so there is no right solution.

In the GNOME realm 2 solutions to the problem have begun to emerge:
1) GStreamer runs a script that reindents your code as a pre-commit hook and with that ensures that you don't have to do any work but the code is still properly intented.
2) Gtk/Glib don't care about indenting a lot as long as the code is still readable. So you can use tabs or spaces freely.
I like both of these solutions as they free the coders (both maintainers and patch submitters) from having to care about indentation.

And for the other projects, they can do the code cleanup themselves. I don't consider it my job to win a beauty contest for them.

Created attachment 167732 [details] [review]
Don't use deprecated GDK drawing APIs

FIXME: This code has one issue left: It removes stippling when dnd is
active. Someone needs to invent a better method to do dnd indications.
There seems to have been code that avoided stippling, but it was deleted
for performance reasons back in the days...

Created attachment 167748 [details] [review]
Don't use deprecated GDK drawing APIs

FIXME: This code has one issue left: It removes stippling when dnd is
active. Someone needs to invent a better method to do dnd indications.
There seems to have been code that avoided stippling, but it was deleted
for performance reasons back in the days...

The latest patch here is updated to fix everything Cosimo complained about on IRC.

As noted in the commit message, I removed al the stippling code. I have no idea what it was used for (and if it was still used), but if someone explains it to me, I'm sure we can come up with a solution.

Thank you very much for the patch; I splitted it into logical pieces and pushed them to master, along with some additional fixes for regressions I found here and there.