After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 624687 - switch-page bug when activated from menu
switch-page bug when activated from menu
Status: RESOLVED FIXED
Product: gtk+
Classification: Platform
Component: Widget: GtkNotebook
2.90.x
Other Linux
: Normal critical
: ---
Assigned To: Christian Dywan
gtk-bugs
: 625101 (view as bug list)
Depends on:
Blocks:
 
 
Reported: 2010-07-18 21:13 UTC by Christian Persch
Modified: 2010-07-23 11:54 UTC
See Also:
GNOME target: ---
GNOME version: ---

Attachments
Correct marshaller for switch-page and adjust emission from menu (1021 bytes, patch)
2010-07-19 09:09 UTC, Christian Dywan 		accepted-commit_now Details | Review

Description Christian Persch 2010-07-18 21:13:00 UTC 
gtk_notebook_menu_switch_page is using the GtkNotebookPage as argument to the switch-page signal, instead of the real widget.

Result: critical warning

Also, the signal itself seems wrong: it uses a VOID:POINTER,INT marshal but passes GTK_TYPE_WIDGET as the POINTER type... should use a VOID:OBJECT,INT marshal.
Comment 1 Christian Dywan 2010-07-19 09:09:39 UTC 
Created attachment 166145 [details] [review]
Correct marshaller for switch-page and adjust emission from menu

Clearly my fault, thanks a lot for the quick report.

The above patch corrects the marshaller to OBJECT_UINT and emits the signal correctly for the context menu.
Comment 2 Christian Dywan 2010-07-23 09:21:05 UTC 
*** Bug 625101 has been marked as a duplicate of this bug. ***
Comment 3 Emmanuele Bassi (:ebassi) 2010-07-23 11:15:51 UTC 
Review of attachment 166145 [details] [review]:

the patch is clearly correct.
Comment 4 Christian Dywan 2010-07-23 11:24:23 UTC 
Committed to master.
Comment 5 Christian Dywan 2010-07-23 11:54:32 UTC 
Committed the menu item change to gtk-2-22 as well, it took a bit longer to re-build and test.