GNOME Bugzilla – Bug 624203
gstutils: Make gst_pad_proxy_getcaps() return empty caps if it's what the other side has
Last modified: 2010-08-05 00:17:31 UTC
gst_pad_proxy_getcaps() as used in "tee" returns ANY (the pad template) instead of EMPTY if the intersection of the children is EMPTY. And it does a g_warning().. Example: import gst c = gst.parse_launch ("fakesrc ! tee name=t ! xvimagesink t. ! alsasink"); print c.get_by_name("t").get_pad("sink").get_caps() Expected: EMPTY Actual result: ANY and a g_warning()
Created attachment 165766 [details] [review] patch
Comment on attachment 165766 [details] [review] patch Looks correct, please push after the release.
Actually, maybe we can keep the two cases plus comments separate, with separate goto done? Lumping them together like this is a bit confusing.
commit 929f41177b064f3b71b130fa2df0f21b10b397a6 Author: Tim-Philipp Müller <tim.muller@collabora.co.uk> Date: Thu Aug 5 01:09:02 2010 +0100 tests: add basic unit test for gst_pad_proxy_getcaps() https://bugzilla.gnome.org/show_bug.cgi?id=624203 commit 8ff0bfc671f025ad22de3f928c87013dd868227e Author: Olivier Crête <olivier.crete@collabora.co.uk> Date: Thu Aug 5 01:06:57 2010 +0100 gstutils: Make gst_pad_proxy_getcaps() return empty caps if it's what the other side has gst_pad_proxy_getcaps() would return the pad template caps if the other side returned empty caps or if the intersection of all the caps on the other side was empty. https://bugzilla.gnome.org/show_bug.cgi?id=624203
And again with the real commit hashes: commit e50267593ef76c9b0a3d2312a316dfca04aeb4fe Author: Tim-Philipp Müller <tim.muller@collabora.co.uk> Date: Thu Aug 5 01:09:02 2010 +0100 tests: add basic unit test for gst_pad_proxy_getcaps() https://bugzilla.gnome.org/show_bug.cgi?id=624203 commit 37e2fb10546c4135aa2afc6dc083564ee12574a4 Author: Olivier Crête <olivier.crete@collabora.co.uk> Date: Thu Aug 5 01:06:57 2010 +0100 gstutils: Make gst_pad_proxy_getcaps() return empty caps if it's what the other side has gst_pad_proxy_getcaps() would return the pad template caps if the other side returned empty caps or if the intersection of all the caps on the other side was empty. https://bugzilla.gnome.org/show_bug.cgi?id=624203