After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 624084 - mirageaudiotest Makefile is missing GStreamer link options
mirageaudiotest Makefile is missing GStreamer link options
Status: RESOLVED FIXED
Product: banshee
Classification: Other
Component: Community Extensions
1.6.1
Other Linux
: Normal normal
: 1.x
Assigned To: Banshee Maintainers
Banshee Maintainers
Depends on:
Blocks:
 
 
Reported: 2010-07-11 05:51 UTC by Theodore Lee
Modified: 2010-08-04 11:11 UTC
See Also:
GNOME target: ---
GNOME version: ---


Attachments
Makefile.in patch (482 bytes, patch)
2010-07-11 05:51 UTC, Theodore Lee
none Details | Review

Description Theodore Lee 2010-07-11 05:51:19 UTC
Created attachment 165661 [details] [review]
Makefile.in patch

mirageaudiotest uses GStreamer, but when it's built libgstreamer isn't specified in the gcc command. This causes the build to fail on systems which require explicit DSO linking (like Fedora does now) with a message like this:

/usr/bin/ld: mirageaudiotest.o: undefined reference to symbol 'gst_init'
/usr/bin/ld: note: 'gst_init' is defined in DSO /usr/lib/libgstreamer-0.10.so.0 so try adding it to the linker command line
/usr/lib/libgstreamer-0.10.so.0: could not read symbols: Invalid operation

The attached patch fixed the problem for me, but my knowledge of make is pretty much non-existent, so I have no idea how correct it is (although I suppose a similar change to Makefile.am in the libmirageaudio directory would have the same effect).
Comment 1 Bertrand Lorentz 2010-08-04 11:11:33 UTC
Thank you for the bug report and the patch.
I applied a similar patch to Makefile.am (Makefile.in is generated from it), to git master and the stable branch.