After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 623914 - since tp-logger history is shown as normal messages in adium themes
since tp-logger history is shown as normal messages in adium themes
Status: RESOLVED FIXED
Product: empathy
Classification: Core
Component: Archives
2.31.x
Other Linux
: Normal normal
: ---
Assigned To: empathy-maint
Depends on:
Blocks:
 
 
Reported: 2010-07-09 07:48 UTC by Nicolò Chieffo
Modified: 2010-07-09 12:18 UTC
See Also:
GNOME target: ---
GNOME version: ---


Attachments
http://git.collabora.co.uk/?p=user/cassidy/empathy;a=shortlog;h=refs/heads/backlog-623914 (1.01 KB, patch)
2010-07-09 10:44 UTC, Guillaume Desmottes
none Details | Review

Description Nicolò Chieffo 2010-07-09 07:48:19 UTC
empathy 2.31.4
tp-logger 0.1.3

I recently got an update that pulled in telepathy-logger. Since that moment empathy stopped showing the history messages with Context.html and NextContext.html, and uses Content.html and NextContent.html.

There was probably a small error when history messages are pulled in from telepathy-logger.
Comment 1 Guillaume Desmottes 2010-07-09 08:25:15 UTC
so you still have backlog from previous conversation but it's not displayed and it used to be. right?
Comment 2 Nicolò Chieffo 2010-07-09 08:56:10 UTC
yes
Comment 3 Guillaume Desmottes 2010-07-09 10:18:42 UTC
which theme are you using btw?
Comment 4 Nicolò Chieffo 2010-07-09 10:21:50 UTC
adium-theme-ubuntu
Comment 5 Nicolò Chieffo 2010-07-09 10:30:23 UTC
Anyway I'm completely sure it's not caused by my theme, since it worked before the empathy upgrade (and the theme was not upgraded).
Unfortunately I don't have time to have a look at empathy code, because I'm under exams now, sorry
Comment 6 Guillaume Desmottes 2010-07-09 10:32:40 UTC
Yeah, I got it. Nice catch!
Comment 7 Guillaume Desmottes 2010-07-09 10:44:39 UTC
Created attachment 165544 [details] [review]
http://git.collabora.co.uk/?p=user/cassidy/empathy;a=shortlog;h=refs/heads/backlog-623914

 libempathy/empathy-message.c |    2 +-
 libempathy/empathy-tp-chat.c |    3 +++
 2 files changed, 4 insertions(+), 1 deletions(-)
Comment 8 Nicolò Chieffo 2010-07-09 10:46:57 UTC
Do you mark also when viewing the previous conversations (using F3)?
Comment 9 Guillaume Desmottes 2010-07-09 11:33:33 UTC
yes
Comment 10 Nicolò Chieffo 2010-07-09 12:03:13 UTC
Did you also check that a normal message must not be appended to a history message?
Comment 11 Guillaume Desmottes 2010-07-09 12:16:24 UTC
yeah yeah, that's all fine with this patch.
Comment 12 Nicolò Chieffo 2010-07-09 12:17:32 UTC
Ok, thank you very much for your work!
Comment 13 Guillaume Desmottes 2010-07-09 12:18:55 UTC
This problem has been fixed in the development version. The fix will be available in the next major software release. Thank you for your bug report.