After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 623854 - jpegparse reads a wrong EXIF section size
jpegparse reads a wrong EXIF section size
Status: RESOLVED FIXED
Product: GStreamer
Classification: Platform
Component: gst-plugins-bad
git master
Other Linux
: Normal normal
: 0.10.20
Assigned To: GStreamer Maintainers
GStreamer Maintainers
Depends on:
Blocks:
 
 
Reported: 2010-07-08 16:26 UTC by Víctor Manuel Jáquez Leal
Modified: 2010-07-08 20:33 UTC
See Also:
GNOME target: ---
GNOME version: ---

Attachments
fix the exif frame size (1.27 KB, patch)
2010-07-08 16:26 UTC, Víctor Manuel Jáquez Leal 		none Details | Review

Description Víctor Manuel Jáquez Leal 2010-07-08 16:26:59 UTC 
Created attachment 165491 [details] [review]
fix the exif frame size

The commit 00897e21a99011884c07c4def20a6d658cc0e97b

brings a regression in images with an EXIF section because it reads an erroneous number of bytes breaking the sections reading, thus the SOF sections are lost and image header is not parsed.

exif_size = size - 2; <--- the exif string length + the padding is missing

The following patch fix this problems.
Comment 1 Thiago Sousa Santos 2010-07-08 17:38:27 UTC 
Thanks for the patch. Added comments and kept the second chunk as it was, seems like elsewhere it shows the full size, then I pushed.

commit 1d57953496ab48178fcb5fa799e2d128362636a2
Author: Víctor Manuel Jáquez Leal <vjaquez@igalia.com>
Date:   Thu Jul 8 17:58:16 2010 +0200

    jpegparse: fix exif frame size
    
    Skip the correct number of bytes when reading exif
    data
    
    Fixes #623854