After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 623815 - Don't check sender for GDBusProxy objects where name is not set
Don't check sender for GDBusProxy objects where name is not set
Status: RESOLVED FIXED
Product: glib
Classification: Platform
Component: gdbus
unspecified
Other Linux
: Normal normal
: ---
Assigned To: David Zeuthen (not reading bugmail)
gtkdev
Depends on:
Blocks:
 
 
Reported: 2010-07-08 09:01 UTC by Peng Huang
Modified: 2010-07-14 15:22 UTC
See Also:
GNOME target: ---
GNOME version: ---

Attachments
A proposal to fix this problem. If the proxy's name_ower is NULL, it does not test the the signal sender anymore. (1.12 KB, patch)
2010-07-08 09:02 UTC, Peng Huang 		none Details | Review

Description Peng Huang 2010-07-08 09:01:12 UTC 
I create a GDBusProxy with a peer to peer connection, and the g-name is NULL. But the GDBusProxy object can not received any signals from peer.
Comment 1 Peng Huang 2010-07-08 09:02:48 UTC 
Created attachment 165460 [details] [review]
A proposal to fix this problem.
If the proxy's name_ower is NULL, it does not test the the signal sender anymore.
Comment 2 David Zeuthen (not reading bugmail) 2010-07-14 15:22:36 UTC 
Actually this works just fine in normal peer-to-peer cases, there's even a test for it. The problem you are running into is that the sender field is set for the GDBusMessage for the signal. So technically we're actually doing the right thing already. I agree, however, that it's useless checking for the sender if the name wasn't set on the proxy. So let's do the patch.

Some comments on the patch

 - functionally, the patch looks fine (ie. it works)

 - the description (both the patch and bug desc) is not accurate. I've
   updated that

 - we generally require test cases for core functionality like this so
   I added one

http://git.gnome.org/browse/glib/commit/?id=497edd8b40edfbf85e029a9300e0d99ac6f08630