GNOME Bugzilla – Bug 623426
Wilber is still on top of toolbox in single window
Last modified: 2011-03-01 21:23:37 UTC
Created attachment 165138 [details] This is the image of our beloved mascot I am referring to. While I was testing 2.7.1, I noticed that GIMP'S mascot Wilbur is still on top of the toolbox when it is switched to single-window mode. It looks wierd, and feels unprofessional. I was wondering if someone could remove it or replace it with a better image when GIMP goes into single window mode.
His name is Wilber, not Wilbur, and he is very angry at you now.
And, what better image?
I am sorry, I am new to GIMP and probably should have double-checked the name first. My apologies to Wilber. Also I was thinking maybe you could have a contest and ask the GIMP community to could up with some alternative images ?
I don't like it either, putting on milestone so we don't forget to discuss it and take a decision.
Maybe it should be the same as in multi window mode (so let Wilber stay), but it should not be cropped at the top. There is no way to see Wilber completely like in multi window mode.
Here is a possible solution (?) to hide Wilber during single-window-mode; app/widgets/gimptoolbox.c under gimp_toolbox_expose_wilber () , if we are in single-window-mode then immediately return FALSE, else go ahead and draw Wilber. questions: How do we check if we are in single-window-mode? Is there a better way ( probably )?
okay. ignore my previous comment. I have a working crude solution. under gimp_toolbox_size_allocate() use; if (config->toolbox_wilber && !config->single_window_mode) { gtk_widget_show( toolbox->p->header ); } else { gtk_widget_hide( toolbox->p->header ); } once again, I am open to better suggestions.
In SWM, to see Wilber drawn on toolbox top as it is in MWM I have to either hide the menubar or add a call to cairo_translate (cr, allocation.x, allocation.y); before cairo_scale (cr, factor, factor); at line 162 of file 'app/widgets/gimpcairo.c'.
Thanks Massimo, fixed that glitch: commit 0bb5a76405de0d9638c44b025729b32426c907bb Author: Michael Natterer <mitch@gimp.org> Date: Tue Mar 1 17:11:22 2011 +0100 app: fix wilber dawing offset on widgets that don't have a window app/widgets/gimpcairo.c | 6 ++++++ 1 files changed, 6 insertions(+), 0 deletions(-)
Thanks Massimo and mitch, this is good enough for 2.8.