After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 623380 - Stop using GnomeDesktopItem and use GKeyFile instead
Stop using GnomeDesktopItem and use GKeyFile instead
Status: RESOLVED INVALID
Product: gnome-tweak-tool
Classification: Applications
Component: general
unspecified
Other All
: Normal normal
: ---
Assigned To: GNOME Tweak Tool maintainer(s)
GNOME Tweak Tool maintainer(s)
plumbing
Depends on:
Blocks:
 
 
Reported: 2010-07-02 12:34 UTC by Vincent Untz
Modified: 2011-05-29 19:38 UTC
See Also:
GNOME target: ---
GNOME version: ---

Attachments
Stop using GnomeDesktopItem and use GKeyFile instead (28.65 KB, patch)
2010-07-02 12:34 UTC, Vincent Untz 		none Details | Review
Rebased patch (17.55 KB, patch)
2010-09-30 00:30 UTC, Andreas Köhler 		none Details | Review

Description Vincent Untz 2010-07-02 12:34:46 UTC 
GnomeDesktopItem should be killed, since it's really some old API that is not interesting anymore now that we have GKeyFile.

I wasn't able to test the patch (g-c-c doesn't build for me), so I can't test and there could be some bad mistakes in there...
Comment 1 Vincent Untz 2010-07-02 12:34:48 UTC 
Created attachment 165102 [details] [review]
Stop using GnomeDesktopItem and use GKeyFile instead
Comment 2 Bastien Nocera 2010-09-22 14:55:48 UTC 
Could you update the patch to apply to the current git master?
Comment 3 Andreas Köhler 2010-09-30 00:30:27 UTC 
Created attachment 171383 [details] [review]
Rebased patch

I tried to rebase the patch to the current head of master. Please note that I have not even tried to compile it! Maybe it helps though.
Comment 4 Bastien Nocera 2010-09-30 11:19:57 UTC 
(In reply to comment #3)
> Created an attachment (id=171383) [details] [review]
> Rebased patch
> 
> I tried to rebase the patch to the current head of master. Please note that I
> have not even tried to compile it! Maybe it helps though.

Well, you wouldn't have been able to, the code isn't compiled, or used, though it would be used in a GNOME Plumbing panel that Vincent is supposed to take care of :)